TTStub revision: modernize/update

[mdhildreth]

PR description:

Updates/modifications/revisions of the TTStub class and the TruthAssociator. Needed for the "modern" version of the L1 Tracking code.

PR validation:

Basic tests completed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[mdhildreth]

please don't review yet...

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28435/12846

• This PR adds an extra 64KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28435/12846/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28435/12846/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly
• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28435/12846/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28435/12846/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[kpedro88]

@mdhildreth this needs to be rebased...

[kpedro88]

@mdhildreth if this is desired for the HLT TDR release, it needs to be ready ASAP; otherwise, it will be delayed till 11_1_X

[mdhildreth]

@kpedro88 - Yes, I know... I just wanted a placeholder here. I'll work on it this weekend.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28435/12971

• This PR adds an extra 60KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28435/12971/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28435/12971/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

Pull request #28435 was updated. @andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @benkrikler, @mdhildreth, @ianna, @cmsbuild, @rekovic, @jfernan2, @fioriNTU, @civanch, @kpedro88 can you please check and sign again.

[cmsbuild]

+1
Tested at: c4555d7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24bd77/4047/summary.html
CMSSW: CMSSW_11_1_X_2019-12-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24bd77/4047/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2798405
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2798062
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[cvuosalo]

+1

[rekovic]

+1

[fabiocos]

@jfernan2 the dqm related part looks simple and straightforward
@civanch @kpedro88 could you please have a look? Also the simulation part looks relatively simple to me

[jfernan2]

+1

[kpedro88]

+upgrade
fixing the "get full units, set half units" convention to something consistent is left for a followup PR

[fabiocos]

@mdhildreth could you please make the backport to 11_0_X? I would like to get ready for the final build

[fabiocos]

+1

@civanch please check and comment for a further iteration in case

[fabiocos]

merge