Low energy GFlash-like parameterization #28437

dmitrySorokin · 2019-11-20T17:08:11Z

PR description:
Implement GFlash-like parameterization for low energy electrons in PbWO4.
This is meant to be used for EcalRegion. This model is disabled by default and controlled by LowEnergyGflashEcal flag.

PR validation:
https://indico.cern.ch/event/861790/contributions/3630534/attachments/1941836/3220043/fast_sim.pdf

cmsbuild · 2019-11-20T17:08:36Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-11-20T17:15:20Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28437/12848

This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28437/12848/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28437/12848/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28437/12848/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28437/12848/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2019-11-21T09:02:02Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-11-21T09:07:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28437/12856

This PR adds an extra 24KB to repository

cmsbuild · 2019-11-21T09:07:53Z

A new Pull Request was created by @dmitrySorokin for master.

It involves the following packages:

SimG4Core/Application

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

civanch · 2019-11-21T10:06:54Z

@dmitrySorokin , it would be good to update this PR:

move two new classes to SimG4Core/GFlash
fitted parameters values can be defined as named constexp
extend a bit description - say that by default simulation results are not affected

civanch · 2019-11-21T10:09:42Z

SimG4Core/Application/python/g4SimHits_cfi.py

@@ -148,6 +148,9 @@
        EMPhysics   = cms.untracked.bool(True),
        HadPhysics  = cms.untracked.bool(True),
        FlagBERT    = cms.untracked.bool(False),
+        LowEnergyGflashEcal = cms.bool(False),
+        LowEnergyGflashEcalEmin = cms.double(0),


@dmitrySorokin , can Emin be non zero?

Yes. One can apply this parametrization in any range.
Like in GFlash it works from 50 GeV to 10 GeV.

civanch · 2019-11-21T10:12:39Z

SimG4Core/Application/src/LowEnergyFastSimModel.cc

+  fastStep.SetTotalEnergyDeposited(fastTrack.GetPrimaryTrack()->GetKineticEnergy());
+
+  const G4double energy = fastTrack.GetPrimaryTrack()->GetKineticEnergy();
+  const G4ThreeVector pos = fastTrack.GetPrimaryTrack()->GetPosition();


may be
const G4ThreeVector&

civanch · 2019-11-21T10:14:53Z

SimG4Core/Application/src/LowEnergyFastSimModel.cc

+
+  G4double inPointEnergy = param.GetInPointEnergyFraction(energy) * energy;
+
+  const auto momDir = fastTrack.GetPrimaryTrack()->GetMomentumDirection();


here const G4ThreeVector& seems to be better

Yes, thanks

cmsbuild · 2019-11-21T10:38:10Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-11-21T11:23:31Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-11-21T11:30:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28437/12863

This PR adds an extra 36KB to repository

cmsbuild · 2019-11-21T11:30:38Z

Pull request #28437 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

civanch · 2019-11-21T12:09:37Z

please test

cmsbuild · 2019-11-21T12:10:07Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3574/console Started: 2019/11/21 13:10

cmsbuild · 2019-11-21T13:49:32Z

+1
Tested at: 74c1f2e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63f9e9/3574/summary.html

cmsbuild · 2019-11-21T13:49:35Z

Comparison job queued.

cmsbuild · 2019-11-21T15:31:51Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63f9e9/3574/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2936360
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2936018
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

civanch · 2019-11-21T15:35:00Z

+1

cmsbuild · 2019-11-21T15:35:28Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

civanch · 2019-11-21T15:35:56Z

I agree, that this development should go to SimG4Core/Application.

fabiocos · 2019-11-23T20:56:47Z

@civanch this development is switched off by default, so merging it is safe. The validation linked to the description is useful to understand the detailed response to the algorithm, anyway I think that a check on full physics events is needed.

fabiocos · 2019-11-23T20:56:51Z

+1

dmitrySorokin added 2 commits November 20, 2019 17:57

add low energy fast sim model

a956187

disable fast sim

25c7c43

cmsbuild added this to the CMSSW_11_0_X milestone Nov 20, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures simulation-pending tests-pending labels Nov 20, 2019

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 20, 2019

dmitrySorokin added 2 commits November 21, 2019 09:56

code-checks

d4b43ed

code-format

364a8d3

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 21, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 21, 2019

civanch reviewed Nov 21, 2019

View reviewed changes

add track param to createNewHit

720bd24

cmsbuild added code-checks-pending and removed code-checks-approved labels Nov 21, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 21, 2019

cmsbuild added tests-started and removed tests-pending labels Nov 21, 2019

cmsbuild added tests-approved and removed tests-started labels Nov 21, 2019

cmsbuild added comparison-available and removed comparison-pending labels Nov 21, 2019

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Nov 21, 2019

cmsbuild added orp-approved and removed orp-pending labels Nov 23, 2019

cmsbuild merged commit cc99f0b into cms-sw:master Nov 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Low energy GFlash-like parameterization #28437

Low energy GFlash-like parameterization #28437

dmitrySorokin commented Nov 20, 2019 •

edited

cmsbuild commented Nov 20, 2019

cmsbuild commented Nov 20, 2019

cmsbuild commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

civanch commented Nov 21, 2019 •

edited

civanch Nov 21, 2019

dmitrySorokin Nov 21, 2019

civanch Nov 21, 2019

dmitrySorokin Nov 21, 2019

civanch Nov 21, 2019

dmitrySorokin Nov 21, 2019

cmsbuild commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

civanch commented Nov 21, 2019

cmsbuild commented Nov 21, 2019 •

edited

cmsbuild commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

civanch commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

civanch commented Nov 21, 2019

fabiocos commented Nov 23, 2019

fabiocos commented Nov 23, 2019


		G4double inPointEnergy = param.GetInPointEnergyFraction(energy) * energy;

		const auto momDir = fastTrack.GetPrimaryTrack()->GetMomentumDirection();

Low energy GFlash-like parameterization #28437

Low energy GFlash-like parameterization #28437

Conversation

dmitrySorokin commented Nov 20, 2019 • edited

cmsbuild commented Nov 20, 2019

cmsbuild commented Nov 20, 2019

cmsbuild commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

civanch commented Nov 21, 2019 • edited

civanch Nov 21, 2019

Choose a reason for hiding this comment

dmitrySorokin Nov 21, 2019

Choose a reason for hiding this comment

civanch Nov 21, 2019

Choose a reason for hiding this comment

dmitrySorokin Nov 21, 2019

Choose a reason for hiding this comment

civanch Nov 21, 2019

Choose a reason for hiding this comment

dmitrySorokin Nov 21, 2019

Choose a reason for hiding this comment

cmsbuild commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

civanch commented Nov 21, 2019

cmsbuild commented Nov 21, 2019 • edited

cmsbuild commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

civanch commented Nov 21, 2019

cmsbuild commented Nov 21, 2019

civanch commented Nov 21, 2019

fabiocos commented Nov 23, 2019

fabiocos commented Nov 23, 2019

dmitrySorokin commented Nov 20, 2019 •

edited

civanch commented Nov 21, 2019 •

edited

cmsbuild commented Nov 21, 2019 •

edited