Modernize SinglePhotonJetPlusHOFilter

[makortel]

PR description:

In the context of #25090 this PR modernizes SinglePhotonJetPlusHOFilter by

• Remove unnecessary counters
• Make members const, initialize in initializer list, use naming convention
• Remove unnecessary includes
• Make the module global
• Use range-for
• Get event data with getHandle()
• Make parameters tracked
• Implement fillDescriptions()

PR validation:

Limited matrix runs.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28456/12883

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

DPGAnalysis/Skims

@chayanit, @pgunnell, @cmsbuild, @zhenhu can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3595/console Started: 2019/11/22 16:07

[cmsbuild]

+1
Tested at: 8fc07b9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c73228/3595/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c73228/3595/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2785613
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785271
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[fabiocos]

@chayanit @pgunnell @kfjack could you please have a look at this PR?

[kfjack]

Hi @fabiocos I checked the test results the skim files have been produced correctly. So the PR should be fine for me. Many thanks.

[chayanit]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1