HGCAL scintillator digitisation: adequate dynamic range (follow up 28349) #28463
Conversation
…guration in the main digitizer cfi
… as before (MIP kept at 15)
…& same adcLSB as before (MIP kept at 15)
…pository franzoni with cms-merge-topic
TOA fix for scintillator - tkx @pfs
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28463/12900
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @franzoni (Giovanni Franzoni) for master. It involves the following packages: RecoLocalCalo/HGCalRecAlgos @perrotta, @civanch, @kpedro88, @cmsbuild, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@civanch any further comment? |
|
Just to mention that since the HGCAL HSci digis are also used in the L1 TPG, I plan to transpose the exact same fix to the L1 sequence. I plan to make an other PR with these changes Today evening (CERN time). |
|
@jbsauvan do I correctly understand that this is needed to avoid inconsistencies? |
|
The L1 TPG assumes the previous HCAL Sci digi format, so it will misinterpret the energy values in the TDC case. |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
cmsbuild
added
comparison-pending
tests-approved
and removed
comparison-available
tests-started
labels
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
+1 |
PR description:
This is a follow up to the PR 28349, which pointed out the necessity of extending the dynamic range for energy of the HGCAL scintillator.
We do it by introducing the realistic digitisation also for the scintillators, even though not all parameters of the electronics and photo detection are currently known. By using the 10 bits of the adc (leaving the LSB un-changed) and the 12 bits for the amplitude measurement after the ToA switch, we are able to extend the saturation value to 1000 MIP (up from 275), which comfortably covers magnitude of physical deposits in the scintillator cells.
PR validation at digi level
We verify that (for 100 ttbar events, no pu, same GEN-SIM for target-pr-> RED and reference->BLACK) with this PR the
modebit of the in-time bunch-crossing (3rd in a window of 5 samples) turns on for the hardest hits,and that the amplitude of the digi themselves is limited to below ~0.8*1024, the current coverage of the adc (the hits which exceed the threshold now use the toA way of recording the amplitude, which has a larger LSB and are therefore buried in the bulk of the distribution).
We verify also that in the bunch-crossing after the in-time sample (4th in a window of 5), more hits are present which stems from shape leakage of the realistic digitisation now used for the scintillators.
No changes in EE and HEfront.
PR validation at rechit level
The spectrum of HGCAL scintillator rechits in statistically unvaried for hits which don't hit the old saturation threshold.
The reconstructed time now happens for hits above the ToA threshold (previously no such thing was possible with the single-BX trivial digitisation). The ball-park values make sense and can enable studies, we don't aim at tuning the details since the actual parameters of the scintillator part are not known.
this PR is not a backport