Changes for new trained regression for UL 2016 - 110X #28466

jainshilpi · 2019-11-25T14:30:38Z

This is exactly the same as #28422. A new PR is created instead of continuing from there since the there were problems with the history and hence further merging

These changes are essential for making the 2016 UL regression work. After discussion with Sam, I have made these changes (since 2016 uses the old PF cluster regression strategy and old ele/pho regressions codes).
We had to create Modifier_run2_ECAL_2016_cff.py so that the training strategy of 2017 and 2018 could be used here as well.

cmsbuild · 2019-11-25T14:31:11Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-11-25T14:36:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28466/12902

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Eras/python/Era_Run2_2016_cff.py modified in PR(s): Changes for new trained regression for UL 2016 - 110X #28422
- File Configuration/Eras/python/Era_Run2_2017_cff.py modified in PR(s): Changes for new trained regression for UL 2016 - 110X #28422
- File Configuration/Eras/python/Modifier_run2_ECAL_2016_cff.py modified in PR(s): Changes for new trained regression for UL 2016 - 110X #28422
- File RecoEgamma/EgammaTools/python/regressionModifier_cfi.py modified in PR(s): Changes for new trained regression for UL 2016 - 110X #28422
- File RecoParticleFlow/PFClusterProducer/python/particleFlowClusterECAL_cff.py modified in PR(s): Changes for new trained regression for UL 2016 - 110X #28422
- File RecoParticleFlow/PFClusterProducer/python/particleFlowClusterOOTECAL_cff.py modified in PR(s): Changes for new trained regression for UL 2016 - 110X #28422

cmsbuild · 2019-11-25T14:36:41Z

A new Pull Request was created by @jainshilpi for master.

It involves the following packages:

Configuration/Eras
RecoEgamma/EgammaTools
RecoParticleFlow/PFClusterProducer

@perrotta, @kpedro88, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@mmarionncern, @Sam-Harper, @clelange, @makortel, @felicepantaleo, @riga, @afiqaize, @rovere, @lgray, @Martin-Grunewald, @sobhatta, @seemasharmafnal, @hatakeyamak, @varuns23, @bachtis, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

slava77 · 2019-11-25T14:42:53Z

@cmsbuild please test

cmsbuild · 2019-11-25T14:43:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3615/console Started: 2019/11/25 15:43
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3621/console Started: 2019/11/25 16:45

cmsbuild · 2019-11-25T17:56:48Z

+1
Tested at: 8a015b0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-908743/3621/summary.html

cmsbuild · 2019-11-25T17:56:52Z

Comparison job queued.

slava77 · 2019-11-25T18:33:29Z

RecoParticleFlow/PFClusterProducer/python/particleFlowClusterOOTECAL_cff.py

-    recHitsEBLabel = "reducedEcalRecHitsEB",
-    recHitsEELabel = "reducedEcalRecHitsEE"
+    particleFlowClusterOOTECAL,
+    energyCorrector = dict(applyMVACorrections = True, maxPtForMVAEvaluation = 90., srfAwareCorrection = False, recHitsEBLabel = "reducedEcalRecHitsEB", recHitsEELabel = "reducedEcalRecHitsEE")


please add linebreak for readability to keep the length within/below 100 chars.

Also, It looks like applyMVACorrections = True is redundant

Hi Slava, yes that is right - removed applyMVACorrections = True.

cmsbuild · 2019-11-25T19:21:11Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-908743/3621/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3252 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2787584
DQMHistoTests: Total failures: 2704
DQMHistoTests: Total nulls: 3
DQMHistoTests: Total successes: 2784536
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.012 KiB( 33 files compared)
DQMHistoSizes: changed ( 136.731 ): -0.012 KiB JetMET/SUSYDQM
Checked 147 log files, 16 edm output root files, 34 DQM output files

slava77 · 2019-11-26T00:33:19Z

@cmsbuild please test
it looks like the unit test failure is transient

cmsbuild · 2019-11-26T00:33:53Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3631/console Started: 2019/11/26 01:34

cmsbuild · 2019-11-26T02:47:59Z

+1
Tested at: 857cfe1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-908743/3631/summary.html

cmsbuild · 2019-11-26T02:48:03Z

Comparison job queued.

cmsbuild · 2019-11-26T04:02:53Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-908743/3631/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3252 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2787584
DQMHistoTests: Total failures: 2704
DQMHistoTests: Total nulls: 3
DQMHistoTests: Total successes: 2784536
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.012 KiB( 33 files compared)
DQMHistoSizes: changed ( 136.731 ): -0.012 KiB JetMET/SUSYDQM
Checked 147 log files, 16 edm output root files, 34 DQM output files

slava77 · 2019-11-26T18:07:36Z

+1

for #28466 857cfe1

code changes are in line with the PR description and the follow up review
jenkins tests pass and comparisons with the baseline show changes only in the 2016 workflows, starting from ECAL cluster corrected energies and then also propagating downstream with additional changes in the egamma objects
a follow up update is expected to simplify the run2 configurations for the future releases as described in merge run2_ECAL_201[678] and run2_egamma_201[678] modifiers (separately) for 11X/master #28482

Based on the discussion in the Nov 26 ORP, this PR is only introducing the configuration changes. There should be a follow up update to the GT to properly complete the update for the 2016 ecal/egamma regressions.

fabiocos · 2019-11-26T21:45:15Z

+operations

the update of Eras and modifier is coherent with the purpose of the PR

cmsbuild · 2019-11-26T21:45:45Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-11-26T21:48:46Z

+1

jainshilpi added 4 commits November 25, 2019 13:54

Took care of 1st hash

8e3924d

Took care of 2nd hash

9517737

Took care of 3rd hash

a0beb9a

Slava's comments

8a015b0

cmsbuild added this to the CMSSW_11_0_X milestone Nov 25, 2019

cmsbuild added code-checks-pending comparison-pending operations-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Nov 25, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 25, 2019

slava77 mentioned this pull request Nov 25, 2019

Changes for new trained regression for UL 2016 - 110X #28422

Closed

cmsbuild added tests-started and removed tests-pending labels Nov 25, 2019

fabiocos mentioned this pull request Nov 25, 2019

Finalization of CMSSW_11_0_X open development #28455

Closed

9 tasks

cmsbuild added tests-approved and removed tests-started labels Nov 25, 2019

slava77 reviewed Nov 25, 2019

View reviewed changes

cmsbuild removed the comparison-pending label Nov 25, 2019

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-rejected labels Nov 26, 2019

cmsbuild added tests-started and removed tests-pending labels Nov 26, 2019

cmsbuild added tests-approved and removed tests-started labels Nov 26, 2019

cmsbuild added comparison-available and removed comparison-pending labels Nov 26, 2019

slava77 mentioned this pull request Nov 26, 2019

merge run2_ECAL_201[678] and run2_egamma_201[678] modifiers (separately) for 11X/master #28482

Open

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Nov 26, 2019

cmsbuild added fully-signed operations-approved and removed operations-pending pending-signatures labels Nov 26, 2019

cmsbuild added orp-approved and removed orp-pending labels Nov 26, 2019

cmsbuild merged commit de9eabe into cms-sw:master Nov 26, 2019

jainshilpi mentioned this pull request Nov 29, 2019

Backport of "Changes for new trained regression for UL 2016" in 10_6_X #28508

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes for new trained regression for UL 2016 - 110X #28466

Changes for new trained regression for UL 2016 - 110X #28466

jainshilpi commented Nov 25, 2019

cmsbuild commented Nov 25, 2019

cmsbuild commented Nov 25, 2019

cmsbuild commented Nov 25, 2019

slava77 commented Nov 25, 2019

cmsbuild commented Nov 25, 2019 •

edited

cmsbuild commented Nov 25, 2019

cmsbuild commented Nov 25, 2019

slava77 Nov 25, 2019

jainshilpi Nov 25, 2019

cmsbuild commented Nov 25, 2019

slava77 commented Nov 26, 2019

cmsbuild commented Nov 26, 2019 •

edited

cmsbuild commented Nov 26, 2019

cmsbuild commented Nov 26, 2019

cmsbuild commented Nov 26, 2019

slava77 commented Nov 26, 2019

fabiocos commented Nov 26, 2019

cmsbuild commented Nov 26, 2019

fabiocos commented Nov 26, 2019

Changes for new trained regression for UL 2016 - 110X #28466

Changes for new trained regression for UL 2016 - 110X #28466

Conversation

jainshilpi commented Nov 25, 2019

cmsbuild commented Nov 25, 2019

cmsbuild commented Nov 25, 2019

cmsbuild commented Nov 25, 2019

slava77 commented Nov 25, 2019

cmsbuild commented Nov 25, 2019 • edited

cmsbuild commented Nov 25, 2019

cmsbuild commented Nov 25, 2019

slava77 Nov 25, 2019

Choose a reason for hiding this comment

jainshilpi Nov 25, 2019

Choose a reason for hiding this comment

cmsbuild commented Nov 25, 2019

slava77 commented Nov 26, 2019

cmsbuild commented Nov 26, 2019 • edited

cmsbuild commented Nov 26, 2019

cmsbuild commented Nov 26, 2019

cmsbuild commented Nov 26, 2019

slava77 commented Nov 26, 2019

fabiocos commented Nov 26, 2019

cmsbuild commented Nov 26, 2019

fabiocos commented Nov 26, 2019

cmsbuild commented Nov 25, 2019 •

edited

cmsbuild commented Nov 26, 2019 •

edited