Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "BTL simulation: OOT effects" #28504

Merged
merged 1 commit into from Nov 29, 2019
Merged

Revert "BTL simulation: OOT effects" #28504

merged 1 commit into from Nov 29, 2019

Conversation

fabiocos
Copy link
Contributor

Temporarily reverts #28433 as it is causing in CMSSW_11_0_X_2019-11-28-1100 a crash in the premixing test wf 20634.99 under investigation.

@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Nov 28, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28504/12955

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

DataFormats/FTLDigi
SimFastTiming/FastTimingCommon

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test workflow 20634.99

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3687/console Started: 2019/11/28 20:28

@cmsbuild
Copy link
Contributor

+1
Tested at: 4354060
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92c614/3687/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92c614/3687/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92c614/3687/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92c614/3687/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-92c614/20634.99_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D41PU_GenSimHLBeamSpotFull14+SingleNuE10_cf_2026D41PU_PremixHLBeamSpotFull14PU_Premix+DigiFullTriggerPUPRMXCombined_2026D41PU+RecoFullGlobalPUPRMX_2026D41PU+HARVESTFullGlobalPU_2026D41PU
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-92c614/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7370 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 8189
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2785310
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor Author

+1

@fabiocos
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 91be707 into master Nov 29, 2019
@fabiocos
Copy link
Contributor Author

@casarsa @kpedro88 @makortel if I produce a fresh new premix library with workflow 20640.98 (100 events, but technically it should work) and I use it as an input to workflow 20634.99, I still get a crash:

Thread 3 (Thread 0x7f9a324e5700 (LWP 20733)):
#0  0x00007f9a5c917bed in poll () from /lib64/libc.so.6
#1  0x00007f9a500743ff in full_read.constprop () from /cvmfs/cms-ib.cern.ch/nweek-02604/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_X_2019-11-27-1100/lib/slc7_amd64_gcc820/pluginFWCoreServicesPlugins.so
#2  0x00007f9a50074b3c in edm::service::InitRootHandlers::stacktraceFromThread() () from /cvmfs/cms-ib.cern.ch/nweek-02604/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_X_2019-11-27-1100/lib/slc7_amd64_gcc820/pluginFWCoreServicesPlugins.so
#3  0x00007f9a50075a19 in sig_dostack_then_abort () from /cvmfs/cms-ib.cern.ch/nweek-02604/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_X_2019-11-27-1100/lib/slc7_amd64_gcc820/pluginFWCoreServicesPlugins.so
#4  <signal handler called>
#5  0x00007f9a3c79b3ef in std::_Hashtable<unsigned int, std::pair<unsigned int const, edm::Ptr<l1t::HGCalTriggerCell> >, std::allocator<std::pair<unsigned int const, edm::Ptr<l1t::HGCalTriggerCell> > >, std::__detail::_Select1st, std::equal_to<unsigned int>, std::hash<unsigned int>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::clear() () from /cvmfs/cms-ib.cern.ch/nweek-02604/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_X_2019-11-27-1100/lib/slc7_amd64_gcc820/libDataFormatsL1THGCal.so
#6  0x00007f9a3c79b451 in std::_Hashtable<unsigned int, std::pair<unsigned int const, edm::Ptr<l1t::HGCalTriggerCell> >, std::allocator<std::pair<unsigned int const, edm::Ptr<l1t::HGCalTriggerCell> > >, std::__detail::_Select1st, std::equal_to<unsigned int>, std::hash<unsigned int>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::~_Hashtable() () from /cvmfs/cms-ib.cern.ch/nweek-02604/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_X_2019-11-27-1100/lib/slc7_amd64_gcc820/libDataFormatsL1THGCal.so
#7  0x00007f9a3c7a41ae in l1t::HGCalCluster::~HGCalCluster() () from /cvmfs/cms-ib.cern.ch/nweek-02604/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_X_2019-11-27-1100/lib/slc7_amd64_gcc820/libDataFormatsL1THGCal.so
#8  0x00007f9a3c88d19f in edm::Wrapper<BXVector<l1t::HGCalCluster> >::~Wrapper() () from /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_0_X_2019-11-28-1100/lib/slc7_amd64_gcc820/pluginL1TriggerL1THGCalPlugins.so
#9  0x00000000004138e7 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() ()
#10 0x00007f9a5f3b2bc8 in edm::DataManagingProductResolver::resetProductData_(bool) () from /cvmfs/cms-ib.cern.ch/nweek-02604/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_X_2019-11-27-1100/lib/slc7_amd64_gcc820/libFWCoreFramework.so
#11 0x00007f9a5f464d13 in edm::Principal::clearPrincipal() () from /cvmfs/cms-ib.cern.ch/nweek-02604/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_X_2019-11-27-1100/lib/slc7_amd64_gcc820/libFWCoreFramework.so
#12 0x00007f9a5f422d87 in edm::EventPrincipal::clearEventPrincipal() () from /cvmfs/cms-ib.cern.ch/nweek-02604/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_X_2019-11-27-1100/lib/slc7_amd64_gcc820/libFWCoreFramework.so
#13 0x00007f9a5f453760 in edm::FunctorWaitingTask<edm::EventProcessor::processEventAsyncImpl(edm::WaitingTaskHolder, unsigned int)::{lambda(std::__exception_ptr::exception_ptr const*)#1}>::execute() () from /cvmfs/cms-ib.cern.ch/nweek-02604/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_X_2019-11-27-1100/lib/slc7_amd64_gcc820/libFWCoreFramework.so
#14 0x00007f9a5dbb027d in tbb::internal::custom_scheduler<tbb::internal::IntelSchedulerTraits>::process_bypass_loop (this=this@entry=0x7f9a59713e00, context_guard=..., t=t@entry=0x7f9a59623a40, isolation=isolation@entry=0) at ../../include/tbb/task.h:992
#15 0x00007f9a5dbb0575 in tbb::internal::custom_scheduler<tbb::internal::IntelSchedulerTraits>::local_wait_for_all (this=0x7f9a59713e00, parent=..., child=<optimized out>) at ../../include/tbb/task.h:992
#16 0x00007f9a5dbaa35f in tbb::internal::arena::process (this=0x7f9a597c2d00, s=...) at ../../src/tbb/arena.cpp:152
#17 0x00007f9a5dba8ed3 in tbb::internal::market::process (this=0x7f9a597c3580, j=...) at ../../src/tbb/market.cpp:667
#18 0x00007f9a5dba55cc in tbb::internal::rml::private_worker::run (this=0x7f9a5ac28100) at ../../src/tbb/private_server.cpp:266
#19 0x00007f9a5dba57d9 in tbb::internal::rml::private_worker::thread_routine (arg=<optimized out>) at ../../src/tbb/private_server.cpp:219
#20 0x00007f9a5cbfae65 in start_thread () from /lib64/libpthread.so.0
#21 0x00007f9a5c92288d in clone () from /lib64/libc.so.6

I believe we need to further investigate this point and better understand its behaviour before safely integrate this code into the release. I revert it for the time being to move forward with other tests in CMSSW_11_0_0_pre13, in case we may consider integrating it back in a last fix round if strongly desired

@smuzaffar smuzaffar deleted the revert-28433-mc-simBTL-OOT branch December 15, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available orp-approved pending-signatures simulation-pending tests-approved upgrade-pending
Projects
None yet
Milestone
CMSSW_11_0_X
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabiocos @cmsbuild