Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM: Remove dqmEndRun in DQMEDAnalyzer #28552

Merged
merged 3 commits into from Jan 9, 2020

Commits on Dec 9, 2019

  1. Remove dqmEndRun from DQMEDAnalyzer.

    ... and also dqmBegin/EndLumi.
    
    This includes lots of automated changes to remove "empty" dqmBeginRun
    and dqmEndRun.
    
    dqmBeginRun remains allowed in DQMEDAnalyzer; it is called before
    booking and ME cannot (and must not) be accessed there. Any local member
    intialization should be fine to do there; it will be called for each of
    the edm::stream instancs once we switch back to stream. Technically all
    the code could simply be moved into bookHistograms, but having a
    separate beginRun makes more sense logically.
    
    Many dqmEndRun that only contain log messages and printouts where
    removed, even if they were more than basic debugging output.
    
    The remaining modules with non-trivial dqmEndRuns are converted to
    DQMOneEDAnalyzer.
    
    Commands like
      sed -i '/dqmBeginRun/,+3d' $(ag \
     'dqm(Begin|End)Run[^\n]*\n[^\n]*LogInfo[^\n]*\n\s*}' -l)
    were used to delete "useless" bodies.
    schneiml committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    c490b35 View commit details
    Browse the repository at this point in the history
  2. Also fix PFJetAnalyzerDQM.

    Not sure how it got lost before.
    schneiml committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    7427d73 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fa5d00a View commit details
    Browse the repository at this point in the history