Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumes Migration for Particle Flow #2858

Merged
merged 11 commits into from Mar 17, 2014
Merged

Conversation

bachtis
Copy link
Contributor

@bachtis bachtis commented Mar 13, 2014

Hi ,
I finalized the consumes migration for all the modules.
This PR contains all the changes except the PFClusterProducer module which is already
migrated and queued in #2730

-Checked that there are no more modules under RecoParticleFlow that need migration
-The development is done on CMSSW_7_1_X_2014-03-13-0200

I would appreciate if you can have a quick look for any major issues/request because I will be in Moriond EWK next week and the response is expected to be slower
Cheers
Michalis

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bachtis for CMSSW_7_1_X.

Consumes Migration for Particle Flow

It involves the following packages:

RecoParticleFlow/PFProducer
RecoParticleFlow/PFTracking

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Mar 14, 2014

+1

for #2858 f57e2a6
jenkins confirmed output ok

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 17, 2014
RecoParticleFlow -- Consumes Migration for Particle Flow
@nclopezo nclopezo merged commit bd94f60 into cms-sw:CMSSW_7_1_X Mar 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants