Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enforceGUIDInFileName option to PoolSource and EmbeddedRootSource (11_0_X) #28586

Merged
merged 8 commits into from Dec 17, 2019
Merged

Add enforceGUIDInFileName option to PoolSource and EmbeddedRootSource (11_0_X) #28586

merged 8 commits into from Dec 17, 2019

Commits on Dec 5, 2019

  1. Add option to enforce GUID in file name to (input) RootFile

    @makortel
    makortel committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    8169bf6 View commit details
    Browse the repository at this point in the history

  2. Update comment 

    Actions.cc does not exist anymore
    @makortel
    makortel committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    8159219 View commit details
    Browse the repository at this point in the history

  3. Simplify maxEvents in test

    @makortel
    makortel committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    162d51b View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2019

  1. Add script to extract GUID and exit code from Framework Job Report

    @makortel
    makortel committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    3534c03 View commit details
    Browse the repository at this point in the history

  2. Check the exit code in the unit test

    @makortel
    makortel committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    2745370 View commit details
    Browse the repository at this point in the history

  3. Move the stem extraction to its own function 

    This way the function can be tested, and the functionality shared elsewhere.
    @makortel
    makortel committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    0413942 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2019

  1. Take parameter via string_view as well 

    To avoid creating temporary strings from const char* arguments.
    @makortel
    makortel committed Dec 7, 2019
    Configuration menu
    Copy the full SHA
    d7ff852 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. Remove redundant use of FWCore/Utilities

    @makortel
    makortel committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    5d93099 View commit details
    Browse the repository at this point in the history