Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define CLCT patterns for Run-3 (CCLUT-1) #28600

Merged
merged 2 commits into from Dec 17, 2019
Merged

Define CLCT patterns for Run-3 (CCLUT-1) #28600

merged 2 commits into from Dec 17, 2019

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Dec 10, 2019

PR description:

During Run-3 the CSC DPG group is planning to run the CSC trigger with new CLCT patterns based on a 12-bit comparator code. They are noticeably different than the ones defined in 2007. An introduction to the new CLCT patterns can be found here [1]. Accordingly, we will have to change the data formats for both CLCT and LCT for Run-3. A proposal for the CLCT is being developed. A proposal for the LCT format can be found here [2], p13.

The plan to integrate the new patterns in the CSCCLCTProcessor is as follows:

  1. Define new patterns (this PR)
  2. Rewrite old patterns in new form
  3. Enable option to construct legacy CSCCLCTDigi with new patterns
  4. Construct new CSCCLCTRun3Digi with new patterns and based on comparator codes

Beyond the above mentioned changes in the CSCCLCTProcessor, there will be changes to the LCT data format in simulation, the (O)TMBs (with and without GEM), the packer/unpacker, the DQM/validation,...

[1]
https://indico.cern.ch/event/778315/contributions/3238278/subcontributions/268636/attachments/1770627/2876988/181213-CCStatus_WNASH.pdf

[2]
https://indico.cern.ch/event/869092/contributions/3664061/subcontributions/294640/attachments/1956917/3252387/Tao_LCTformat_20191204.pdf

PR validation:

Compiled the code

if this PR is a backport please specify the original PR:

N/A

@tahuang1991 @ptcox

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

1 similar comment
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28600/13113

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 11, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3924/console Started: 2019/12/11 14:30

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f18ac8/3924/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2800084
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2799742
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Dec 17, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a18be55 into cms-sw:master Dec 17, 2019
@dildick dildick deleted the from-CMSSW_11_1_X_2019-12-09-1100-Run3-CLCT-patterns branch February 4, 2020 22:01
@dildick dildick changed the title Define CLCT patterns for Run-3 Define CLCT patterns for Run-3 (CCLUT-1) Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants