EventSetup consumes migration for TrackingMonitor #28635

wddgit · 2019-12-16T22:54:12Z

PR description:

EventSetup consumes migration for TrackingMonitor.

(Note there are many more of these coming on other modules with similar style. Let me know if you have any problems with how this is being done.)

PR validation:

Relies on existing tests. There is not any new functionality. Results should stay exactly the same.

cmsbuild · 2019-12-16T22:54:41Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-12-16T22:58:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28635/13182

This PR adds an extra 52KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/TrackingMonitor/interface/TrackAnalyzer.h modified in PR(s): DQM: new DQMStore. #28622, Introduce changes in order to switch from LumiScalers to MetaData #27677
- File DQM/TrackingMonitor/interface/TrackingMonitor.h modified in PR(s): Introduce changes in order to switch from LumiScalers to MetaData #27677
- File DQM/TrackingMonitor/src/TrackAnalyzer.cc modified in PR(s): DQM: new DQMStore. #28622, Introduce changes in order to switch from LumiScalers to MetaData #27677
- File DQM/TrackingMonitor/src/TrackingMonitor.cc modified in PR(s): DQM: new DQMStore. #28622, Introduce changes in order to switch from LumiScalers to MetaData #27677

cmsbuild · 2019-12-16T22:58:43Z

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

DQM/TrackingMonitor

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @mtosi, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

wddgit · 2019-12-16T23:02:33Z

please test

cmsbuild · 2019-12-16T23:03:02Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4005/console Started: 2019/12/17 00:04

makortel · 2019-12-16T23:03:54Z

DQM/TrackingMonitor/src/TrackAnalyzer.cc

@@ -259,8 +269,7 @@ void TrackAnalyzer::bookHistosForEfficiencyFromHitPatter(DQMStore::IBooker& iboo
    }
  }

-  edm::ESHandle<TrackerGeometry> trackerGeometry;
-  iSetup.get<TrackerDigiGeometryRecord>().get(trackerGeometry);
+  TrackerGeometry const& trackerGeometry = iSetup.get<TrackerDigiGeometryRecord>().get(trackerGeometryToken_);


This could be just

Suggested change

TrackerGeometry const& trackerGeometry = iSetup.get<TrackerDigiGeometryRecord>().get(trackerGeometryToken_);

TrackerGeometry const& trackerGeometry = iSetup.getData(trackerGeometryToken_);

no?

Thanks much. That is better. I had forgotten about the new function getData. Saves some typing when ESGetTokens are used. No reason to type the record type again. I fixed this here and in the other places this occurs in this PR.

cmsbuild · 2019-12-17T00:36:14Z

+1
Tested at: 523d0f5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c724b/4005/summary.html
CMSSW: CMSSW_11_1_X_2019-12-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2019-12-17T00:36:17Z

Comparison job queued.

cmsbuild · 2019-12-17T05:54:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c724b/4005/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2798405
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2798063
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

cmsbuild · 2019-12-17T20:22:00Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-12-17T20:27:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28635/13200

This PR adds an extra 52KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/TrackingMonitor/interface/TrackAnalyzer.h modified in PR(s): DQM: new DQMStore. #28622, Introduce changes in order to switch from LumiScalers to MetaData #27677
- File DQM/TrackingMonitor/interface/TrackingMonitor.h modified in PR(s): Introduce changes in order to switch from LumiScalers to MetaData #27677
- File DQM/TrackingMonitor/src/TrackAnalyzer.cc modified in PR(s): DQM: new DQMStore. #28622, Introduce changes in order to switch from LumiScalers to MetaData #27677
- File DQM/TrackingMonitor/src/TrackingMonitor.cc modified in PR(s): DQM: new DQMStore. #28622, Introduce changes in order to switch from LumiScalers to MetaData #27677

wddgit · 2019-12-17T20:27:32Z

please test

cmsbuild · 2019-12-17T20:27:35Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4038/console Started: 2019/12/17 21:28

cmsbuild · 2019-12-17T20:27:36Z

Pull request #28635 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

cmsbuild · 2019-12-17T21:56:23Z

+1
Tested at: 3beba35
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c724b/4038/summary.html
CMSSW: CMSSW_11_1_X_2019-12-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2019-12-17T21:56:26Z

Comparison job queued.

cmsbuild · 2019-12-17T23:21:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c724b/4038/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2798405
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2798063
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

jfernan2 · 2019-12-18T07:47:53Z

+1

cmsbuild · 2019-12-18T07:48:19Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-12-18T09:28:39Z

+1

EventSetup consumes migration for TrackingMonitor

523d0f5

cmsbuild added this to the CMSSW_11_1_X milestone Dec 16, 2019

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Dec 16, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 16, 2019

cmsbuild added tests-started and removed tests-pending labels Dec 16, 2019

makortel reviewed Dec 16, 2019

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Dec 17, 2019

cmsbuild added comparison-available and removed comparison-pending labels Dec 17, 2019

cmsbuild mentioned this pull request Dec 17, 2019

DQM: new DQMStore. #28622

Merged

Use getData function

3beba35

cmsbuild removed code-checks-approved comparison-available tests-approved labels Dec 17, 2019

cmsbuild added code-checks-pending comparison-pending tests-pending labels Dec 17, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 17, 2019

cmsbuild added tests-started and removed tests-pending labels Dec 17, 2019

cmsbuild added tests-approved and removed tests-started labels Dec 17, 2019

cmsbuild added comparison-available and removed comparison-pending labels Dec 17, 2019

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Dec 18, 2019

cmsbuild added orp-approved and removed orp-pending labels Dec 18, 2019

cmsbuild merged commit 55f99fa into cms-sw:master Dec 18, 2019

wddgit deleted the esConsumesTrackingMonitor branch January 31, 2020 15:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EventSetup consumes migration for TrackingMonitor #28635

EventSetup consumes migration for TrackingMonitor #28635

wddgit commented Dec 16, 2019

cmsbuild commented Dec 16, 2019

cmsbuild commented Dec 16, 2019

cmsbuild commented Dec 16, 2019

wddgit commented Dec 16, 2019

cmsbuild commented Dec 16, 2019 •

edited

makortel Dec 16, 2019

wddgit Dec 17, 2019

makortel Dec 17, 2019

cmsbuild commented Dec 17, 2019

cmsbuild commented Dec 17, 2019

cmsbuild commented Dec 17, 2019

cmsbuild commented Dec 17, 2019

cmsbuild commented Dec 17, 2019

wddgit commented Dec 17, 2019

cmsbuild commented Dec 17, 2019 •

edited

cmsbuild commented Dec 17, 2019

cmsbuild commented Dec 17, 2019

cmsbuild commented Dec 17, 2019

cmsbuild commented Dec 17, 2019

jfernan2 commented Dec 18, 2019

cmsbuild commented Dec 18, 2019

fabiocos commented Dec 18, 2019

	TrackerGeometry const& trackerGeometry = iSetup.get<TrackerDigiGeometryRecord>().get(trackerGeometryToken_);
	TrackerGeometry const& trackerGeometry = iSetup.getData(trackerGeometryToken_);

EventSetup consumes migration for TrackingMonitor #28635

EventSetup consumes migration for TrackingMonitor #28635

Conversation

wddgit commented Dec 16, 2019

PR description:

PR validation:

cmsbuild commented Dec 16, 2019

cmsbuild commented Dec 16, 2019

cmsbuild commented Dec 16, 2019

wddgit commented Dec 16, 2019

cmsbuild commented Dec 16, 2019 • edited

makortel Dec 16, 2019

Choose a reason for hiding this comment

wddgit Dec 17, 2019

Choose a reason for hiding this comment

makortel Dec 17, 2019

Choose a reason for hiding this comment

cmsbuild commented Dec 17, 2019

cmsbuild commented Dec 17, 2019

cmsbuild commented Dec 17, 2019

cmsbuild commented Dec 17, 2019

cmsbuild commented Dec 17, 2019

wddgit commented Dec 17, 2019

cmsbuild commented Dec 17, 2019 • edited

cmsbuild commented Dec 17, 2019

cmsbuild commented Dec 17, 2019

cmsbuild commented Dec 17, 2019

cmsbuild commented Dec 17, 2019

jfernan2 commented Dec 18, 2019

cmsbuild commented Dec 18, 2019

fabiocos commented Dec 18, 2019

cmsbuild commented Dec 16, 2019 •

edited

cmsbuild commented Dec 17, 2019 •

edited