Herwig7.1.4 to 94X #28649
Herwig7.1.4 to 94X #28649
Conversation
|
A new Pull Request was created by @Andrej-CMS for CMSSW_9_4_X. It involves the following packages: Configuration/Generator @SiewYan, @cmsbuild, @efeyazgan, @mkirsano, @chayanit, @zhenhu, @kpedro88, @pgunnell, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
to be tested with cms-sw/cmsdist#5439 and WorkFlow 535 introduced in this PR for 94X. |
|
test parameters |
|
@mrodozov @smuzaffar is that the correct syntax for the new feature? |
|
yes, but you still need to explicitly start the tests using "please test" comment |
|
please test |
|
The tests are being triggered in jenkins.
|
|
-1 Tested at: 7215f6a CMSSW: CMSSW_9_4_X_2019-12-17-2300 I found follow errors while testing this PR Failed tests: Build ClangBuild
I found compilation error when building: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc630/external/thepeg/2.1.4-8fdb16/include/ThePEG/Pointer/RCPtr.h: In instantiation of 'ThePEG::Pointer::RCPtr& ThePEG::Pointer::RCPtr::create(ThePEG::Pointer::RCPtr::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::RCPtr::const_reference = const ThePEG::LesHouchesInterface&]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc630/external/thepeg/2.1.4-8fdb16/include/ThePEG/Pointer/RCPtr.h:131:22: required from 'static ThePEG::Pointer::RCPtr ThePEG::Pointer::RCPtr::Create(ThePEG::Pointer::RCPtr::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::RCPtr::const_reference = const ThePEG::LesHouchesInterface&]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc630/external/thepeg/2.1.4-8fdb16/include/ThePEG/Pointer/RCPtr.h:889:69: required from 'static ThePEG::Pointer::PtrTraits >::pointer ThePEG::Pointer::PtrTraits >::create(ThePEG::Pointer::PtrTraits >::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::PtrTraits >::pointer = ThePEG::Pointer::RCPtr; ThePEG::Pointer::PtrTraits >::const_reference = const ThePEG::LesHouchesInterface&]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc630/external/thepeg/2.1.4-8fdb16/include/ThePEG/Pointer/PtrTraits.h:204:55: required from 'typename ThePEG::Pointer::Ptr::pointer ThePEG::Pointer::new_ptr(const T&) [with T = ThePEG::LesHouchesInterface; typename ThePEG::Pointer::Ptr::pointer = ThePEG::Pointer::RCPtr]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_9_4_X_2019-12-17-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc:38:53: required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc630/external/thepeg/2.1.4-8fdb16/include/ThePEG/Pointer/RCPtr.h:152:11: error: invalid new-expression of abstract class type 'ThePEG::LesHouchesInterface'
ptr = new T(t);
^~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_9_4_X_2019-12-17-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc:30:7: note: because the following virtual functions are pure within 'ThePEG::LesHouchesInterface':
class LesHouchesInterface : public LesHouchesReader {
^~~~~~~~~~~~~~~~~~~
I found compilation error while trying to compile with clang. Command used: >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_9_4_X_2019-12-17-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGHadronizer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_9_4_X_2019-12-17-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_9_4_X_2019-12-17-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc:10:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc630/external/thepeg/2.1.4-8fdb16/include/ThePEG/Interface/ClassDocumentation.h:13:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc630/external/thepeg/2.1.4-8fdb16/include/ThePEG/Config/ThePEG.h:23:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc630/external/thepeg/2.1.4-8fdb16/include/ThePEG/Pointer/RCPtr.h:152:15: error: allocating an object of abstract class type 'ThePEG::LesHouchesInterface'
ptr = new T(t);
^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc6_amd64_gcc630/external/thepeg/2.1.4-8fdb16/include/ThePEG/Pointer/RCPtr.h:131:14: note: in instantiation of member function 'ThePEG::Pointer::RCPtr::create' requested here
return p.create(t);
^
|
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
@Andrej-CMS do you understand the source of the error? |
|
@Andrej-CMS what is the status of this PR? |
|
@Andrej-CMS do you have any news on this PR? |
|
I'm closing this PR since there was no activity in the last weeks. You can open it back again as soon as you have any news. |
PR description:
This PR introduces Herwig7 to 94X to be able to run the generator in the 5TeV campaign.
The PR introduces the Interface, the python configuration files to be used in official production, and the workflow 535 with which this PR should be tested.
PR validation:
Was tested with WF 535 (backported here). Tested with fragment from TOP-RunIIFall18wmLHEGS-00358 with :
cmsDriver.py GeneratorInterface/Herwig7Interface/python/TOP-RunIIFall18wmLHEGS-00358-fragment.py --fileout file:TOP-RunIIFall18wmLHEGS-00358.root --mc --eventcontent RAWSIM,LHE --datatier GEN-SIM,LHE --conditions 94X_mc2017_realistic_forppRef5TeV --beamspot Realistic5TeVppCollision2017 --step LHE,GEN,SIM --nThreads 8 --geometry DB:Extended --era Run2_2017_ppRef
Also ran a test with numberEventsInLuminosityBlock= cms.untracked.uint32(20) with 350 events.
if this PR is a backport please specify the original PR:
#26905