Remove CondCore/PluginSystem package and BuildFile.xml in ReleaseScripts

[guitargeek]

PR description:

By chance I noticed that the CondCore/PluginSystem package does not contain anything besides a header file which only includes a header file from another package. The current build configuration I use does not like it if there is a BuildFile.xml in a package without any sources in src:

https://github.com/cms-sw/cmssw/tree/master/CondCore/PluginSystem

I also removed Utilities/ReleaseScripts/BuildFile.xml for the same reason. Am I assuming correctly that empty BuildFiles serve no purpose at this point?

PR validation:

CMSSW compiles and local matrix tests pass.

if this PR is a backport please specify the original PR:

No backport intended.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28652/13217

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondCore/EcalPlugins/src/plugin.cc modified in PR(s): ECAL for Time dependent MC. Premix option C. Handle for APD/PN tag for time dependence #28214

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

BigProducts/Simulation
CondCore/ESSources
CondCore/EcalPlugins
CondCore/GEMPlugins
CondCore/HIPlugins
CondCore/JetMETPlugins
CondCore/PluginSystem
CondCore/RPCPlugins
CondCore/RecoMuonPlugins
CondCore/SiPhase2TrackerPlugins
CondCore/SiStripPlugins
CondTools/BTau
CondTools/L1Trigger
CondTools/L1TriggerExt
JetMETCorrections/FFTJetModules
JetMETCorrections/Modules
PhysicsTools/MVAComputer
RecoBTag/PerformanceDB
RecoEgamma/EgammaTools
RecoHI/HiMuonAlgos
TopQuarkAnalysis/TopEventSelection
TopQuarkAnalysis/TopJetCombination
Utilities/ReleaseScripts

@perrotta, @smuzaffar, @benkrikler, @Dr15Jones, @tlampen, @christopheralanwest, @civanch, @mdhildreth, @cmsbuild, @rekovic, @franzoni, @tocheng, @slava77, @ggovi, @pohsun, @santocch can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jainshilpi, @emilbols, @argiro, @jshlee, @wddgit, @varuns23, @seemasharmafnal, @mmarionncern, @kreczko, @ahinzmann, @smoortga, @acaudron, @lgray, @jdolen, @sobhatta, @ferencek, @mandrenguyen, @HeinerTholen, @yetkinyilmaz, @Sam-Harper, @kurtejung, @tocheng, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mmusich, @dgulhan, @clelange, @echapon, @MiheeJo, @jazzitup, @JyothsnaKomaragiri, @mverzett, @yenjie, @afiqaize, @mariadalfonso, @pvmulder, @andrzejnovak this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

@smuzaffar Please review the need for BigProducts/Simulation/BuildFile.xml and Utilities/ReleaseScripts/BuildFile.xml.

[smuzaffar]

@guitargeek , please do not remove BigProducts/Simulation/BuildFile.xml. This is needed to build big Simulation plugin using sources of packages listed in it.

[guitargeek]

Interesting, thanks for the quick answer! I'll put if back quickly of course.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28652/13219

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondCore/EcalPlugins/src/plugin.cc modified in PR(s): ECAL for Time dependent MC. Premix option C. Handle for APD/PN tag for time dependence #28214

[cmsbuild]

Pull request #28652 was updated. @perrotta, @smuzaffar, @benkrikler, @Dr15Jones, @tlampen, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @franzoni, @slava77, @ggovi, @pohsun, @santocch can you please check and sign again.

[slava77]

this PR affects mostly alca.
Some comments or/and a signature would be nice (so that e.g. the reco signature can later be ~trivially applied)

[silviodonato]

this PR affects mostly alca.
Some comments or/and a signature would be nice (so that e.g. the reco signature can later be ~trivially applied)
@christopheralanwest @franzoni @tlampen @pohsun @tocheng

[tlampen]

+1

[slava77]

+1

for #28652 35904a0

• technical
• jenkins tests pass

[santocch]

+1

[silviodonato]

Kind reminder to
core: @Dr15Jones @smuzaffar @makortel
db: @ggovi
l1: @benkrikler @rekovic

[makortel]

@smuzaffar Could you double-check that the changes in Utilities/ReleaseScripts are ok?

[smuzaffar]

@makortel , yes changes in Utilities/ReleaseScripts look good

[makortel]

+1

Thanks

[slava77]

ping

db: @ggovi
l1: @benkrikler @rekovic

we need your signature here.
Please check.
Thank you.

[silviodonato]

It would be great if you can sign this PR by today in order to have it in CMSSW_11_1_0_pre2
db: @ggovi
l1: @benkrikler @rekovic

[ggovi]

+1

[silviodonato]

merge
@benkrikler @rekovic this PR moves CondCore/PluginSystem/interface/registration_macros.h -> CondCore/ESSources/interface/registration_macros.h . Please let us know if you have any comments.