Adapted Phase2 Tracker Digitizer code to C++11 standard #28664

suchandradutta · 2019-12-20T12:20:38Z

PR description:

overall code optimization which includes

Optimization of loops over simhits with std::copy_if
Use of std::make_unique (C++14)
STL loop improvement
Clean-up of unnecessary header files, temporary variables, superfluous code
Style uniformity

PR validation:

Digis validated using FourFourMuon (Pt: 10-100 GeV) + 200 PU events in CMSSW_11_1_X
( workflow number 20610.0 ) against the released version

Details can be found in the presentation : https://indico.cern.ch/event/838963/contributions/3679018/attachments/1964986/3267155/Digitizer_Code_Review_19Dec19.pdf

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions
@subirsarkar @emiglior

…TL loop improvement, Clean-up, Style uniformity

cmsbuild · 2019-12-20T12:21:10Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-12-20T12:27:58Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28664/13232

This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28664/13232/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28664/13232/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28664/13232/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28664/13232/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

kpedro88 · 2019-12-20T16:28:37Z

@suchandradutta please apply the code-checks and code-format, otherwise the PR tests will not start.
Also, please update the PR title to make it clear that it refers to the Phase 2 tracker digitization code.

cmsbuild · 2019-12-21T05:22:51Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-12-21T05:27:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28664/13242

This PR adds an extra 36KB to repository

cmsbuild · 2019-12-21T05:28:12Z

A new Pull Request was created by @suchandradutta (Suchandra Dutta) for master.

It involves the following packages:

SimTracker/SiPhase2Digitizer

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2019-12-21T05:43:40Z

please test

cmsbuild · 2019-12-21T05:44:06Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4083/console Started: 2019/12/21 06:44

cmsbuild · 2019-12-21T06:57:02Z

+1
Tested at: bcf49c7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d43235/4083/summary.html
CMSSW: CMSSW_11_1_X_2019-12-20-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2019-12-21T06:57:06Z

Comparison job queued.

cmsbuild · 2020-01-15T15:36:57Z

Pull request #28664 was updated. @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please check and sign again.

suchandradutta · 2020-01-15T15:37:55Z

Prior to the last commit I suspect I had an un-cleaned build and the compilation error did not show up! Sorry for that!

kpedro88 · 2020-01-15T15:39:42Z

please test

cmsbuild · 2020-01-15T15:40:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4232/console Started: 2020/01/15 16:42

cmsbuild · 2020-01-15T16:56:00Z

+1
Tested at: 91abd9c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d43235/4232/summary.html
CMSSW: CMSSW_11_1_X_2020-01-14-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-01-15T16:56:04Z

Comparison job queued.

cmsbuild · 2020-01-15T18:27:34Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d43235/4232/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2711715
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2711368
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

silviodonato · 2020-01-21T08:13:52Z

CMSSW_11_1_X will be used to run a rereco of GEN-SIM-DIGI-RAW produced with CMSSW_11_0_X for the HLT TDR.
This PR will not break the compatibility because it does not change the data format of the tracker digi.
@suchandradutta could you confirm this PR will not break this compatibility?

suchandradutta · 2020-01-21T08:52:46Z

Yes I can confirm that this PR will not break the compatibility

silviodonato · 2020-01-21T14:48:13Z

Kind reminder of this PR to
upgrade: @kpedro88
simulation: @mdhildreth @civanch

kpedro88 · 2020-01-21T15:32:59Z

+upgrade

civanch · 2020-01-21T15:47:33Z

+1

cmsbuild · 2020-01-21T15:47:59Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-01-21T17:42:59Z

+1

Code Optimization : loop using std::copy_if, Use std::make_unique, S…

b794f0d

…TL loop improvement, Clean-up, Style uniformity

cmsbuild added this to the CMSSW_11_1_X milestone Dec 20, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels Dec 20, 2019

cmsbuild added code-checks-rejected and removed code-checks-pending labels Dec 20, 2019

code-checks and code-format are performed

bcf49c7

cmsbuild added code-checks-pending and removed code-checks-rejected labels Dec 21, 2019

suchandradutta changed the title ~~Adapted code to C++11 standard~~ Adapted Phase2 Tracker Digitizer code to C++11 standard Dec 21, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 21, 2019

cmsbuild added tests-started and removed tests-pending labels Dec 21, 2019

cmsbuild removed the tests-started label Dec 21, 2019

cmsbuild added the code-checks-approved label Jan 15, 2020

cmsbuild added tests-started and removed tests-pending labels Jan 15, 2020

cmsbuild added tests-approved and removed tests-started labels Jan 15, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jan 15, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Jan 21, 2020

cmsbuild removed pending-signatures simulation-pending labels Jan 21, 2020

cmsbuild added fully-signed simulation-approved labels Jan 21, 2020

cmsbuild added orp-approved and removed orp-pending labels Jan 21, 2020

cmsbuild merged commit 4067565 into cms-sw:master Jan 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adapted Phase2 Tracker Digitizer code to C++11 standard #28664

Adapted Phase2 Tracker Digitizer code to C++11 standard #28664

suchandradutta commented Dec 20, 2019 •

edited

cmsbuild commented Dec 20, 2019

cmsbuild commented Dec 20, 2019

kpedro88 commented Dec 20, 2019

cmsbuild commented Dec 21, 2019

cmsbuild commented Dec 21, 2019

cmsbuild commented Dec 21, 2019

kpedro88 commented Dec 21, 2019

cmsbuild commented Dec 21, 2019 •

edited

cmsbuild commented Dec 21, 2019

cmsbuild commented Dec 21, 2019

cmsbuild commented Jan 15, 2020

suchandradutta commented Jan 15, 2020

kpedro88 commented Jan 15, 2020

cmsbuild commented Jan 15, 2020 •

edited

cmsbuild commented Jan 15, 2020

cmsbuild commented Jan 15, 2020

cmsbuild commented Jan 15, 2020

silviodonato commented Jan 21, 2020

suchandradutta commented Jan 21, 2020

silviodonato commented Jan 21, 2020

kpedro88 commented Jan 21, 2020

civanch commented Jan 21, 2020

cmsbuild commented Jan 21, 2020

silviodonato commented Jan 21, 2020

Adapted Phase2 Tracker Digitizer code to C++11 standard #28664

Adapted Phase2 Tracker Digitizer code to C++11 standard #28664

Conversation

suchandradutta commented Dec 20, 2019 • edited

PR description:

PR validation:

cmsbuild commented Dec 20, 2019

cmsbuild commented Dec 20, 2019

kpedro88 commented Dec 20, 2019

cmsbuild commented Dec 21, 2019

cmsbuild commented Dec 21, 2019

cmsbuild commented Dec 21, 2019

kpedro88 commented Dec 21, 2019

cmsbuild commented Dec 21, 2019 • edited

cmsbuild commented Dec 21, 2019

cmsbuild commented Dec 21, 2019

cmsbuild commented Jan 15, 2020

suchandradutta commented Jan 15, 2020

kpedro88 commented Jan 15, 2020

cmsbuild commented Jan 15, 2020 • edited

cmsbuild commented Jan 15, 2020

cmsbuild commented Jan 15, 2020

cmsbuild commented Jan 15, 2020

silviodonato commented Jan 21, 2020

suchandradutta commented Jan 21, 2020

silviodonato commented Jan 21, 2020

kpedro88 commented Jan 21, 2020

civanch commented Jan 21, 2020

cmsbuild commented Jan 21, 2020

silviodonato commented Jan 21, 2020

suchandradutta commented Dec 20, 2019 •

edited

cmsbuild commented Dec 21, 2019 •

edited

cmsbuild commented Jan 15, 2020 •

edited