Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate SiStripDCSStatus to getByToken #2867

Merged
merged 2 commits into from Apr 14, 2014

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Mar 14, 2014

migrate SiStripDCSStatus and Strip DQM files which make use of it to getByToken

modified: CalibTracker/SiStripCommon/BuildFile.xml

modified: CalibTracker/SiStripCommon/interface/ShallowClustersProducer.h

modified: CalibTracker/SiStripCommon/interface/SiStripDCSStatus.h

modified: CalibTracker/SiStripCommon/plugins/ShallowClustersProducer.cc

modified: CalibTracker/SiStripCommon/plugins/SiStripDCSFilter.cc

modified: CalibTracker/SiStripCommon/src/SiStripDCSStatus.cc

modified: DQM/SiStripMonitorCluster/src/SiStripMonitorCluster.cc

modified: DQM/SiStripMonitorDigi/src/SiStripMonitorDigi.cc

modified: DQM/SiStripMonitorTrack/src/SiStripMonitorTrack.cc

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_1_X.

migrate SiStripDCSStatus to getByToken

It involves the following packages:

CalibTracker/SiStripCommon
DQM/SiStripMonitorCluster
DQM/SiStripMonitorDigi
DQM/SiStripMonitorTrack

@ojeda, @danduggan, @rovere, @cmsbuild, @diguida, @rcastello, @deguio, @Degano, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mtosi
Copy link
Contributor Author

mtosi commented Mar 14, 2014

@thspeer @threus

@cmsbuild
Copy link
Contributor

Pull request #2867 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @diguida, @rcastello, @deguio, @Degano, @nclopezo can you please check and sign again.

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Mar 17, 2014

+1

@davidlange6
Copy link
Contributor

ping alca?

@diguida
Copy link
Contributor

diguida commented Apr 13, 2014

+1
Sorry, @davidlange6 overlooked it

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 14, 2014
Consumes -- Migrate SiStripDCSStatus to getByToken
@ktf ktf merged commit c8debf4 into cms-sw:CMSSW_7_1_X Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants