New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DDCMS unit tests by restoring missing ROOT element table #28671
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28671/13239
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages: DetectorDescription/DDCMS @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
type bug-fix |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
please test with cms-sw/cmsdist#5376 |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28671/13254
|
Pull request #28671 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @silviodonato (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The latest version of DD4hep CMS is trying to integrate includes a change that eliminates the ROOT default element table CMS was using. DDCMS unit tests fail when this table is missing.
There are various options for CMS to rebuild this table, but the simplest one is to just make a call to have ROOT rebuild it. We can consider other solutions in coming months.
This PR fixes issue #28476 and enables external PR 5376 (new DD4hep version) to go forward.
PR validation:
This fix has been tested with the new version of DD4hep to verify it works.
No backport.