Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of HLT menus to 11_1_0_pre1 Template (11_1_X) #28681

Merged
merged 1 commit into from Dec 28, 2019

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

Migration of HLT menus to 11_1_0_pre1 Template (11_1_X)
Plus integration of CMSHLT-2100
Based on CMSSW_11_1_0_pre1

PR validation:

TSG tests

if this PR is a backport please specify the original PR:

N/A

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28681/13249

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @silviodonato you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 23, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4097/console Started: 2019/12/23 18:27

@cmsbuild
Copy link
Contributor

+1
Tested at: 33c76b5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9bc5f1/4097/summary.html
CMSSW: CMSSW_11_1_X_2019-12-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9bc5f1/4097/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2813219
  • DQMHistoTests: Total failures: 233
  • DQMHistoTests: Total nulls: 176
  • DQMHistoTests: Total successes: 2812469
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1176.076 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -575.399 KiB HLT/JME
  • DQMHistoSizes: changed ( 11634.0,... ): -11.514 KiB HLT/HLTJETMET
  • DQMHistoSizes: changed ( 11634.0,... ): -0.844 KiB HLT/GeneralHLTOffline
  • DQMHistoSizes: changed ( 11634.0,... ): -0.281 KiB HLT/TAU
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @silviodonato (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@Martin-Grunewald I understand that the changes for the 2021 and 2023 scenarios are expected, am I correct?

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 01d7bf8 into cms-sw:master Dec 28, 2019
@Martin-Grunewald
Copy link
Contributor Author

@fabiocos
Yes, they are expected!

@Martin-Grunewald Martin-Grunewald deleted the HLTmigrationTo1110pre1 branch October 27, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants