Remove global declarations in classes.h in L1THGCal

[Dr15Jones]

PR description:

The declaration of a variable of a given type is no longer necessary to generate a ROOT dictionary.

This was found by the static analyzer.

PR validation:

The code compiles and the resultant .rootmap file is functionally equivalent.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28693/13269

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/L1THGCal

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@amarini, @jbsauvan, @rovere, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @silviodonato you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4116/console Started: 2019/12/30 21:31

[cmsbuild]

+1
Tested at: 655e4df
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20e3b6/4116/summary.html
CMSSW: CMSSW_11_1_X_2019-12-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20e3b6/4116/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2815513
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2815166
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[kpedro88]

+upgrade

[Dr15Jones]

ping

[kpedro88]

@rekovic @benkrikler please sign

[silviodonato]

+1
@benkrikler @rekovic please have a look

[silviodonato]

merge