Test also ESGetToken in ESTestAnalyzers

[makortel]

PR description:

This PR suggests to test also ESGetToken to retrieve ESProducts in ESTestAnalyzers.

Fixes #28709.

PR validation:

Currently the TestProcessor unit test fails. Unit tests run.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28708/13290

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/Integration

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @silviodonato you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

To demonstrate failure

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4134/console Started: 2020/01/03 16:51

[cmsbuild]

+1
Tested at: 2027f81
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2d5a8/4134/summary.html
CMSSW: CMSSW_11_1_X_2020-01-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2d5a8/4134/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2815513
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2815166
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[Dr15Jones]

@makortel the test did not appear to fail.

[makortel]

Right, because the changes did not trigger tests of FWCore/TestProcessor. If you want, I can add a dummy change in there to trigger the tests.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28708/13297

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #28708 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4147/console Started: 2020/01/06 18:37

[cmsbuild]

+1
Tested at: 917af3f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2d5a8/4147/summary.html
CMSSW: CMSSW_11_1_X_2020-01-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2d5a8/4147/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2815513
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2815166
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[makortel]

TestProcessor tests are now run successfully

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @silviodonato (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1