Support for TensorFlow 2.1 #28711
Support for TensorFlow 2.1 #28711
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28711/13293
|
|
test parameters
|
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @riga (Marcel R.) for master. It involves the following packages: DQMServices/Core @perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28711/13296
|
|
@santocch can you please have a look, and sign if you think so? |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
cmsbuild
added
comparison-pending
tests-approved
and removed
comparison-available
tests-started
labels
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
|
+1 |
This PR provides changes to the PhysicsTools/TensorFlow interface to support TensorFlow 2.1.
It should be tested with
cms-sw/cmsdist#5427cms-sw/cmsdist#5525.As documented in cms-sw/cmsdist#5427 (comment) , one of the tests (AOT compilation) currently fails. It requires a change to the
--entry_pointargument in the cmssw-config/SCRAM/GMake/Makefile.dnn build rule, which - as far as I can see - is no longer allowed to start with two underscores as of 2.0 (@smuzaffar). The [WIP] label can be removed once this is settled. All other tests pass.The changes solely focus on 2.0 compatibility and thus target CPU support only. GPU support is planned and will be subject to a future PR, which will also contain features to simplify device placement and working with GPU memory (in coordination with the Patatrack team).
Smaller changes:
PhysicsTools/TensorFlow/python/tools.pyto aid graph reading and writing.DQMServices/Core/src/ROOTFilePB.pb.{cc,h}for the new protobuf version (viaprotoc --cpp_out=`pwd` ROOTFilePB.proto).Edit: Performance comparison of the DeepJet model (from #28711 (comment) below, using testDeepJetPerformance.cc):