Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes required to compile with TBB 2021.2 #33474

Merged
merged 11 commits into from May 4, 2021

Conversation

gartung
Copy link
Member

@gartung gartung commented Apr 19, 2021

PR description:

Changes required to compile with TBB v2021.2
Requires cms-sw/cmsdist#6792

PR validation:

Tested with TBB v2021.2

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33474/22179

  • This PR adds an extra 68KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33474/22180

  • This PR adds an extra 68KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

CondCore/Utilities
DetectorDescription/Core
FWCore/PluginManager
FWCore/Services
FWCore/Utilities
HLTrigger/Timer
PhysicsTools/TensorFlow

@perrotta, @smuzaffar, @civanch, @Dr15Jones, @makortel, @cvuosalo, @fwyzard, @ianna, @mdhildreth, @Martin-Grunewald, @jpata, @cmsbuild, @slava77, @ggovi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @riga, @wddgit, @Martin-Grunewald, @mmusich, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33474/22194

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #33474 was updated. @perrotta, @smuzaffar, @civanch, @Dr15Jones, @makortel, @cvuosalo, @fwyzard, @ianna, @mdhildreth, @Martin-Grunewald, @jpata, @cmsbuild, @slava77, @ggovi can you please check and sign again.

@cvuosalo
Copy link
Contributor

cvuosalo commented May 3, 2021

+1

@makortel
Copy link
Contributor

makortel commented May 3, 2021

+1

@fwyzard
Copy link
Contributor

fwyzard commented May 3, 2021

+1

@perrotta
Copy link
Contributor

perrotta commented May 4, 2021

+1

  • Technical, already approved by Core
  • Jenkins tests pass

@silviodonato
Copy link
Contributor

kind reminder @cms-sw/db-l2

@ggovi
Copy link
Contributor

ggovi commented May 4, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor

See #33642 .
Actually I noticed the warnings, but I though it was not related to this PR since the PR does not change anything in EventFilter/Utilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet