Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add std::atomic_flag to exception list #28712

Conversation

gartung
Copy link
Member

@gartung gartung commented Jan 6, 2020

This adds std::atomic_flag to the list of classes that can be considered thread safe,

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

The code-checks are being triggered in jenkins.

@gartung
Copy link
Member Author

gartung commented Jan 6, 2020

@makortel @Dr15Jones

@makortel
Copy link
Contributor

makortel commented Jan 6, 2020

Thanks!

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28712/13298

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @silviodonato you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Jan 6, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4148/console Started: 2020/01/06 18:47

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

+1
Tested at: bd21047
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-713bc2/4148/summary.html
CMSSW: CMSSW_11_1_X_2020-01-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-713bc2/4148/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2815513
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2815166
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @silviodonato (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1964132 into cms-sw:master Jan 7, 2020
@gartung gartung deleted the gartung-Utilities-StaticAnalyzers-skip-std-atomic-flag branch March 16, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants