New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix python includes for ALCARECOSiPixelCalCosmics to comply with Py3 #28722
fix python includes for ALCARECOSiPixelCalCosmics to comply with Py3 #28722
Conversation
The code-checks are being triggered in jenkins. |
please test for CMSSW_11_1_PY3_X |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28722/13325
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Calibration/TkAlCaRecoProducers @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@mmusich - much simpler changes can be made if the only requirement is to make this file's syntax python3 compatible. [eg, just adding a '.' to the import] |
@davidlange6 yeah I considered that, but it would be the unique occurrence of this pattern among the files in this subsystem, so I chose to go with the whole path as done everywhere else. |
Comparison is ready Comparison Summary:
|
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
PR description:
Fixes issue reported at #28535 (comment)
PR validation:
This was tested successfully in
CMSSW_11_1_PY3_X_2020-01-08-2300
with:runTheMatrix.py -l 7.22,7.21,7.4,7.3 -t 4 -j 8
and also with:
if this PR is a backport please specify the original PR:
This PR is not a backport, but this commit shall be taken as well in the 10.6.X backport of #28535 (i.e. #28574)
cc:
@tvami