Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix python includes for ALCARECOSiPixelCalCosmics to comply with Py3 #28722

Merged
merged 1 commit into from Jan 9, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 9, 2020

PR description:

Fixes issue reported at #28535 (comment)

PR validation:

This was tested successfully in CMSSW_11_1_PY3_X_2020-01-08-2300 with: runTheMatrix.py -l 7.22,7.21,7.4,7.3 -t 4 -j 8
and also with:

cmsDriver.py -s RAW2DIGI,RECO,ALCA:SiPixelCalCosmics --data --scenario cosmics --conditions 110X_dataRun2_2017_2018_Candidate_2019_11_21_04_11_05 --eventcontent=ALCARECO --datatier ALCARECO -n -1 --no_exec --era Run2_2018 --python_filename=SiPixelCalCosmics_2018_v1.py --nThreads=8 --dasquery='file dataset=/Cosmics/Commissioning2018-v1/RAW run=313084'

if this PR is a backport please specify the original PR:

This PR is not a backport, but this commit shall be taken as well in the 10.6.X backport of #28535 (i.e. #28574)

cc:
@tvami

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2020

The code-checks are being triggered in jenkins.

@silviodonato
Copy link
Contributor

please test for CMSSW_11_1_PY3_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28722/13325

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2020

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Calibration/TkAlCaRecoProducers

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @threus, @tocheng this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2020

+1
Tested at: a71992f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0b80a/4179/summary.html
CMSSW: CMSSW_11_1_PY3_X_2020-01-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@tlampen
Copy link
Contributor

tlampen commented Jan 9, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

@mmusich - much simpler changes can be made if the only requirement is to make this file's syntax python3 compatible. [eg, just adding a '.' to the import]

@mmusich
Copy link
Contributor Author

mmusich commented Jan 9, 2020

@davidlange6 yeah I considered that, but it would be the unique occurrence of this pattern among the files in this subsystem, so I chose to go with the whole path as done everywhere else.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0b80a/4179/summary.html

Comparison Summary:

  • No significant changes to the logs found

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4182/console Started: 2020/01/09 14:03

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2020

+1
Tested at: a71992f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0b80a/4182/summary.html
CMSSW: CMSSW_11_1_X_2020-01-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0b80a/4182/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2815513
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2815166
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e932388 into cms-sw:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants