-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing HB thresholds E/gamma saved rec-hits for run3 : 11_0_0 #28724
Fixing HB thresholds E/gamma saved rec-hits for run3 : 11_0_0 #28724
Conversation
A new Pull Request was created by @Sam-Harper (Sam Harper) for CMSSW_11_0_X. It involves the following packages: RecoEgamma/EgammaIsolationAlgos @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
abort test |
Jenkins tests are aborted. |
this changes the default behavior for a production release for run3 and phase-2 workflows. However, the reducedHcalRecHits have a limited use scope and one may argue for an exception. |
ah, maybe I'm wrong and we still did not validate 11_0_0 for production. In that case, it may be fine for this bugfix. @silviodonato please clarify where we are now |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
okay let me know if this in policy or not. If not I'll try and find another solution. Will be at the ORP meeting on tuesday to discuss further. |
@srimanob , in case you know the current status |
@slava77 @Sam-Harper |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Bug fixes to the HB threshold to be correct for Run3 for the hits e/gmama saves for Hcal studies
backport of #28723