Fixing HB thresholds E/gamma saved rec-hits for run3 : 11_0_0

[Sam-Harper]

PR description:

Bug fixes to the HB threshold to be correct for Run3 for the hits e/gmama saves for Hcal studies

backport of #28723

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for CMSSW_11_0_X.

It involves the following packages:

RecoEgamma/EgammaIsolationAlgos

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@afiqaize, @jainshilpi, @sobhatta, @varuns23, @lgray this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4197/console Started: 2020/01/10 16:33

[slava77]

abort test

[cmsbuild]

Jenkins tests are aborted.

[slava77]

this changes the default behavior for a production release for run3 and phase-2 workflows.
Nominally this is not allowed by the no-change policy.
The usual solution is to provide the new/changing feature with a (non-default) configuration change.
It seems to me that a customise_command can easily be passed at job submission; it can also be formalized a bit more robustly with a customise python method.

However, the reducedHcalRecHits have a limited use scope and one may argue for an exception.
But this requires some discussion and signoff in some (PPD or/and ORP) meeting.

[slava77]

Nominally this is not allowed by the no-change policy.

ah, maybe I'm wrong and we still did not validate 11_0_0 for production. In that case, it may be fine for this bugfix.

@silviodonato please clarify where we are now

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4199/console Started: 2020/01/10 22:57

[cmsbuild]

+1
Tested at: 6dfe29f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ceb82/4199/summary.html
CMSSW: CMSSW_11_0_X_2020-01-10-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ceb82/4199/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 62 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2793840
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2793493
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[Sam-Harper]

okay let me know if this in policy or not. If not I'll try and find another solution. Will be at the ORP meeting on tuesday to discuss further.

[slava77]

Nominally this is not allowed by the no-change policy.

ah, maybe I'm wrong and we still did not validate 11_0_0 for production. In that case, it may be fine for this bugfix.

@silviodonato please clarify where we are now

@srimanob , in case you know the current status

[srimanob]

@slava77 @Sam-Harper
Thanks for pointing me to this PR. Final validation on 11_0_0 for Run-3/Phase-2 is just starting. We assumed that no much change wrt. to pre13. I think we should be able to cover this bug fix.

[slava77]

+1

for #28724 6dfe29f

• the backport is correct by virtue of using the same topic branch as in Fixing HB thresholds E/gamma saved rec-hits for run3  #28723
• changes in jenkins are only in the reduced hcal rechit collection, as in the master version
• the changes in reco output in this PR were accepted in the Jan 14 ORP.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1