Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Crash in DaqTestHistograms (11_0_X) #28752

Merged
merged 1 commit into from Jan 17, 2020

Conversation

smorovic
Copy link
Contributor

PR description:

Problem was introduced in #28092 commit:
bb6f53f
Fixes (removes) a call into uninitialized pointer.

PR validation:

Verified to work in DAQ (HLT) test environment.

if this PR is a backport please specify the original PR:

Backport of #28751

bb6f53f (using uninitialized pointer)
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2020

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_11_0_X.

It involves the following packages:

DQM/HLTEvF

@Martin-Grunewald, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU, @fwyzard can you please review it and eventually sign? Thanks.
@missirol, @mtosi this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4249/console Started: 2020/01/16 16:53
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4251/console Started: 2020/01/16 16:57

@silviodonato
Copy link
Contributor

Backport of #28751

@silviodonato
Copy link
Contributor

@smorovic the title of this PR says "(10X)" but you are using CMSSW_11_0_X

@smorovic smorovic changed the title Bugfix: Crash in DaqTestHistograms (10X) Bugfix: Crash in DaqTestHistograms (11X) Jan 16, 2020
@smorovic
Copy link
Contributor Author

@silviodonato thanks, I corrected the title. it intended for 11_0_X.

@smorovic smorovic changed the title Bugfix: Crash in DaqTestHistograms (11X) Bugfix: Crash in DaqTestHistograms (11_0_X) Jan 16, 2020
@cmsbuild
Copy link
Contributor

+1
Tested at: 517ff22
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06b379/4251/summary.html
CMSSW: CMSSW_11_0_X_2020-01-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06b379/4251/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793497
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ce5b6eb into cms-sw:CMSSW_11_0_X Jan 17, 2020
@smorovic smorovic deleted the 110X_fix_DAQ_histograms branch May 9, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants