Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mkFit customization in initialStep with a Modifier #28755

Merged
merged 1 commit into from Jan 19, 2020

Conversation

makortel
Copy link
Contributor

PR description:

As found in #28678 (comment) the customize function turned out to be too fragile.

PR validation:

Workflow 11634.7 runs.

The customize function turned out to be fragile.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28755/13394

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Configuration/ProcessModifiers
Configuration/PyReleaseValidation
RecoTracker/IterativeTracking
RecoTracker/MkFit

@perrotta, @pgunnell, @chayanit, @zhenhu, @kpedro88, @cmsbuild, @silviodonato, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@makortel
Copy link
Contributor Author

@cmsbuild, please abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4256/console Started: 2020/01/16 22:05

@makortel
Copy link
Contributor Author

@cmsbuild, please abort

@cmsbuild
Copy link
Contributor

Jenkins tests are aborted.

@makortel
Copy link
Contributor Author

@cmsbuild, please test workflow 11634.7

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 68c0af5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65cb5c/4257/summary.html
CMSSW: CMSSW_11_1_X_2020-01-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65cb5c/4257/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2711715
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2711368
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

+operations

@perrotta
Copy link
Contributor

+1

  • It reproduces with a Modifier what was previously coded with a customization
  • This fixes the issue obsereved in the IB since the integration of Move Sequence to Task Reconstruction_cff #28678, and now wf 11634.7 is set up correctly and can run to conclusion
  • Jenkins tests pass

@chayanit
Copy link

+1

@silviodonato
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor

merge
(@kpedro88 please have a look)

@cmsbuild cmsbuild merged commit 48e1294 into cms-sw:master Jan 19, 2020
@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants