MTD geometry: TDR ETL design (scenario D53) #28788
Conversation
… implementation, add corresponding sensitive volumes
…ETL TDR model detid
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28788/13467
|
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test no official test workflow specific for D53 yet implemented |
|
The tests are being triggered in jenkins. |
|
Comparison is ready Comparison Summary:
|
|
@civanch @kpedro88 do you have further comments? I have ready the update of the material validation, but as that is under the DQM hat I would prefer to keep it in a separate PR to speed things up. @icosivi has also prepared a preliminary version of the DDMTDLinear algorithm for dd4hep, but as far as I can see it still needs work (the positions are not equivalent to the DDD version), therefore I will add it separately in another PR too. |
|
@fabiocos , materials seems to be improved substantially. |
|
@cvuosalo any comment? |
|
+upgrade |
|
|
||
| for (int i = 0; i < m_n; ++i) { | ||
| DDTranslation tran = basetr + (double(i) * m_delta) * direction; | ||
| cpv.position(ddname, mother, copy, tran, rotation); |
There was a problem hiding this comment.
@cvuosalo there is already a DD4hep version in development by @icosivi, see fabiocos@a46c3d0
We would like to address this in a separate PR anyway
There was a problem hiding this comment.
BTW, this is moving along the port of @ianna https://cmssdt.cern.ch/lxr/source/DetectorDescription/DDCMS/plugins/dd4hep/DDLinear.cc
|
+1 |
|
@civanch @silviodonato any objection to move forward? |
|
+1 |
|
+operations |
cmsbuild
added
fully-signed
operations-approved
and removed
operations-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
In this PR the ETL description is updated to reproduce the design discussed into the MTD TDR. The code is based on the reorganization of version D50, with the ETL xml description implemented manually by @icosivi (no more dependence on tkLayout) and a new DDMTDLinear algorithm (an extension of DDLinear) added (only for DDD, DD4hep version to follow).
A numbering scheme is introduced, compatible with the existing
ETLDetId, which is updated with the addition of methods useful to navigate the new geometry (but formally backward compatible, although useless).The reconstruction geometry will be adapted in a following PR, using this one as starting point.
PR validation:
The numbering scheme provides the desired description by running the
TestMTDNumberinganalyzer. @icosivi confirms that the positions shown byTestMTDPositionare the desired ones. The version committed passes the g4 overlap check without problems (details removed to avoid them need to be clarified with people implementing the engineering drawing).A presentation of the implementation can be found in https://indico.cern.ch/event/870274/contributions/3670170/attachments/1962036/3261490/F.Siviero_ETL-Geometry_12.13.2019.pdf and https://indico.cern.ch/event/870274/contributions/3670170/attachments/1962036/3261324/MTD_20191213.pdf (not the latest setup, but discussing the basic features).