New unit test to check if valgrind memory leaks functionality is working

[smuzaffar]

PR description:

Valgrind in CMSSW is broken and does not report even simple memory leaks ( https://hypernews.cern.ch/HyperNews/CMS/get/swDevelopment/3546/2/1/1/2/1/1/1/1/2/1/1/1/1/1.html
) . This PR adds a unit tests to make sure that valgrind in CMSSW env actually works for memory leaks. More tests can be added later.

PR validation:

Build and run locally. This should be tests along with cms-sw/cmsdist#5502

[cmsbuild]

The code-checks are being triggered in jenkins.

[smuzaffar]

test parameters

• pull_requests = updated valgrind to version 3.15.0; use official valgrind sources cmsdist#5502

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28805/13506

• This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28805/13506/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28805/13506/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[smuzaffar]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28805/13507

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5502
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4379/console Started: 2020/01/28 10:53

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

Utilities/ReleaseScripts

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 33f05f9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c66217/4379/summary.html
CMSSW: CMSSW_11_1_X_2020-01-27-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c66217/4379/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697090
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2696743
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[smuzaffar]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1