Clean-up SIMP particles simulation

[civanch]

PR description:

Recently, in #28763 a set of classes for simulation of SIMP exotic particles was forward-ported from 7_1. These classes are incompatible with new Geant4 10.6, because original authors overwrite too many virtual methods of classes. This broke GEANT4 IB (https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc820/CMSSW_11_1_GEANT4_X_2020-01-27-1100/SimG4Core/CustomPhysics). The reason: only public methods of Geant4 classes are stable between versions 10.0 and 10.6, private and protected method signatures potentially may be changed.

This PR includes general clean-up, which means removal all unnecessary things.

PR validation:

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28814/13523

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28814/13523/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28814/13523/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[civanch]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28814/13525

• This PR adds an extra 20KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4392/console Started: 2020/01/28 21:18

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/CustomPhysics

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 6e52c6b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c07908/4392/summary.html
CMSSW: CMSSW_11_1_X_2020-01-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[fabiocos]

@civanch thanks, failures look unrelated to this PR as far as I can see...

[civanch]

please test

Let us test in master

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4405/console Started: 2020/01/29 13:46

[cmsbuild]

+1
Tested at: 3c87f42
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c07908/4405/summary.html
CMSSW: CMSSW_11_1_X_2020-01-29-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c07908/4405/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-c07908/136.793_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697068
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2696721
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[civanch]

@silviodonato , can you, please, take care of this PR? The bug blocks GEANT4 IB.

[silviodonato]

+1

[civanch]

@smuzaffar , this PR should fix GEANT4 IB