New offline DQM module for SMP #28833

anmehta · 2020-01-31T00:06:17Z

PR description: this PR includes the implementation of the offline dqm module for cmssw release validation task for the smp pag. This C++ module includes distributions based on leptons, jets and missing transverse momentum corresponding to Z, W, and VBS-like scenarios.

the code has been tested locally and the results were presented in the SMP General meetings:
https://indico.cern.ch/event/850145/
https://indico.cern.ch/event/868776/

PR validation:

the results have been validated using the drell-yan MC and data rel-val samples from different years of data-taking.

ran the scram build with code checks and format options and the suggested changes are included in the code.

cmsbuild · 2020-01-31T00:06:44Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-01-31T00:11:41Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28833/13566

This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28833/13566/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28833/13566/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-01-31T00:16:28Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-01-31T00:21:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28833/13567

This PR adds an extra 24KB to repository

cmsbuild · 2020-01-31T00:21:29Z

A new Pull Request was created by @anmehta (anmehta) for master.

It involves the following packages:

DQM/Physics

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@rappoccio this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

anmehta · 2020-01-31T00:31:15Z

please test workflow 1330.0,2017.9,2018.9,1320.0

jfernan2 · 2020-01-31T07:55:29Z

@anmehta please add a proper title to this PR and description/validation of itself. Thanks

anmehta · 2020-01-31T14:16:02Z

@anmehta please add a proper title to this PR and description/validation of itself. Thanks

@jfernan2 i've added some description about the PR. sorry, about having missed this earlier.

jfernan2 · 2020-01-31T14:18:51Z

Thanks @anmehta can you please add a proper title to PR too, specifying this is SMP and DQM related?

anmehta · 2020-01-31T14:27:26Z

Thanks @anmehta can you please add a proper title to PR too, specifying this is SMP and DQM related?

@jfernan2, i was not sure if I could do that but now it's done. hopefully this is better. I would like to test workflows before the final review. can i initiate them now ?

anmehta · 2020-02-01T12:09:47Z

@prebello please check.

prebello · 2020-02-01T12:29:03Z

please test workflow 1330.0,2017.9,2018.9,1320.0

Hi @jfernan2 , this is long waited DQM module for the CMSSW release validation of SMP PAG. Please guide @anmehta to properly adjust it for the next releases in DQM. The code is already validated by the SMP group. Not sure if I am still allowed to review PRs :-)

fabiocos · 2020-02-01T16:26:08Z

DQM/Physics/src/SMPDQM.cc

+  unsigned int pvMult = 0;
+
+  if (verbose)
+    cout << "check this" << pvs->size() << endl;


@anmehta general comment here and elsewhere: please replace cout with a suitable choice for the MessageLogger, depending on the severity of the message. cout is not thread safe

cmsbuild · 2020-02-03T16:43:28Z

The code-checks are being triggered in jenkins.

anmehta · 2020-02-03T16:44:10Z

@jfernan2, fixed those and running cmsCodeRulesChecker now gives nothing. thanks!

cmsbuild · 2020-02-03T16:49:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28833/13612

This PR adds an extra 24KB to repository

cmsbuild · 2020-02-03T16:49:28Z

Pull request #28833 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

jfernan2 · 2020-02-03T17:52:36Z

please test

cmsbuild · 2020-02-03T17:52:59Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4481/console Started: 2020/02/03 19:14

cmsbuild · 2020-02-03T19:27:04Z

+1
Tested at: b76a408
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a26ff/4481/summary.html
CMSSW: CMSSW_11_1_X_2020-02-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-02-03T19:27:07Z

Comparison job queued.

cmsbuild · 2020-02-03T20:57:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a26ff/4481/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2697068
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2696721
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 237.625 KiB( 33 files compared)
DQMHistoSizes: changed ( 1000.0,... ): 9.505 KiB Physics/SMP
Checked 147 log files, 16 edm output root files, 34 DQM output files

jfernan2 · 2020-02-04T08:07:03Z

+1
@anmehta I have added you as DQM Validation developer since I understand this is the case

cmsbuild · 2020-02-04T08:07:30Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-02-04T09:07:52Z

+1

anmehta added 2 commits January 31, 2020 00:47

first version of the smp offline dqm module

27a57cb

code checks

68b43dc

cmsbuild added this to the CMSSW_11_1_X milestone Jan 31, 2020

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jan 31, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 31, 2020

scram build code-format

d0193d6

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 31, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 31, 2020

anmehta changed the title ~~From cmssw 11 1 x 2020 01 29 1100 smpdq mcode~~ offline_SMP_ DQM_module__for_pdmV Jan 31, 2020

fabiocos reviewed Feb 1, 2020

View reviewed changes

cmsbuild added comparison-pending tests-pending labels Feb 3, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 3, 2020

cmsbuild added tests-started and removed tests-pending labels Feb 3, 2020

cmsbuild added tests-approved and removed tests-started labels Feb 3, 2020

cmsbuild added comparison-available and removed comparison-pending labels Feb 3, 2020

cmsbuild added dqm-approved and removed dqm-pending pending-signatures labels Feb 4, 2020

cmsbuild added the fully-signed label Feb 4, 2020

silviodonato changed the title ~~offline_SMP_ DQM_module__for_pdmV~~ New offline DQM module for SMP Feb 4, 2020

cmsbuild added orp-approved and removed orp-pending labels Feb 4, 2020

cmsbuild merged commit f015141 into cms-sw:master Feb 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New offline DQM module for SMP #28833

New offline DQM module for SMP #28833

anmehta commented Jan 31, 2020 •

edited

cmsbuild commented Jan 31, 2020

cmsbuild commented Jan 31, 2020

cmsbuild commented Jan 31, 2020

cmsbuild commented Jan 31, 2020

cmsbuild commented Jan 31, 2020

anmehta commented Jan 31, 2020

jfernan2 commented Jan 31, 2020

anmehta commented Jan 31, 2020

jfernan2 commented Jan 31, 2020

anmehta commented Jan 31, 2020

anmehta commented Feb 1, 2020

prebello commented Feb 1, 2020

fabiocos Feb 1, 2020

cmsbuild commented Feb 3, 2020

anmehta commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

jfernan2 commented Feb 3, 2020

cmsbuild commented Feb 3, 2020 •

edited

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

jfernan2 commented Feb 4, 2020

cmsbuild commented Feb 4, 2020

silviodonato commented Feb 4, 2020

New offline DQM module for SMP #28833

New offline DQM module for SMP #28833

Conversation

anmehta commented Jan 31, 2020 • edited

PR description: this PR includes the implementation of the offline dqm module for cmssw release validation task for the smp pag. This C++ module includes distributions based on leptons, jets and missing transverse momentum corresponding to Z, W, and VBS-like scenarios.

PR validation:

cmsbuild commented Jan 31, 2020

cmsbuild commented Jan 31, 2020

cmsbuild commented Jan 31, 2020

cmsbuild commented Jan 31, 2020

cmsbuild commented Jan 31, 2020

anmehta commented Jan 31, 2020

jfernan2 commented Jan 31, 2020

anmehta commented Jan 31, 2020

jfernan2 commented Jan 31, 2020

anmehta commented Jan 31, 2020

anmehta commented Feb 1, 2020

prebello commented Feb 1, 2020

fabiocos Feb 1, 2020

Choose a reason for hiding this comment

cmsbuild commented Feb 3, 2020

anmehta commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

jfernan2 commented Feb 3, 2020

cmsbuild commented Feb 3, 2020 • edited

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

cmsbuild commented Feb 3, 2020

jfernan2 commented Feb 4, 2020

cmsbuild commented Feb 4, 2020

silviodonato commented Feb 4, 2020

anmehta commented Jan 31, 2020 •

edited

cmsbuild commented Feb 3, 2020 •

edited