Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove statics v4 #2885

Merged
merged 23 commits into from Apr 13, 2014
Merged

Conversation

davidlange6
Copy link
Contributor

make PFGeometry a typical class - remove unused parts of it (as I understand the plan is to change to the CMS geometry in the future in any case)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 for CMSSW_7_1_X.

Remove statics v4

It involves the following packages:

RecoParticleFlow/PFTracking

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@nclopezo
Copy link
Contributor

@davidlange6
Hi David,

This pull request is unmergeable, could you please rebase it?

dnikolop and others added 16 commits March 18, 2014 18:32
I forgot (or actually didn't know) to remove this when the
SeedingLayerSetsBuilderESProducer was removed.
Reco fixes -- Remove TYPELOOKUP_DATA_REG(SeedingLayerSetsBuilder)
DQMOffline/Trigger -- Removing old unused top-related modules in DQMOffline/Trigger
Validation/Performance -- Minor code modifications
DQMServices/FwkIO -- add check on the axis labels when merging histograms
…_for_Digitizers

Sim -- Mixing save pileup info for digitizers
FastSimulation/PileUpProducer -- pu scenario for CSA14, based on FastSimulation/PileUpProducer
HLTrigger/Tools -- Update HLT tools scripts for new RunRegistry
@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Mar 25, 2014

+1

for #2885 95a797d
based on code check (had to do in command line) and using jenkins outputs for comparisons: no diffs

@ktf
Copy link
Contributor

ktf commented Apr 9, 2014

@davidlange6 any reason why you did not sign this?

@davidlange6
Copy link
Contributor Author

no. - (its my PR even..) - I'm merging.

davidlange6 added a commit that referenced this pull request Apr 13, 2014
@davidlange6 davidlange6 merged commit bcd1cc5 into cms-sw:CMSSW_7_1_X Apr 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet