Run3 hcx249 Test and verify HcalParameter correctly extracted in the dd4hep scenario

[bsunanda]

PR description:

Only applicable for dd4hep interface. It makes use of #28863

PR validation:

Tested with cfg files in the test area Geometry/HcalCommonData/test/python

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28868/13631

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/src/Filter.cc modified in PR(s): [DD4hep] Allow full regular expression in evaluation #28863

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28868/13631/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28868/13631/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28868/13632

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/src/Filter.cc modified in PR(s): [DD4hep] Allow full regular expression in evaluation #28863

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/HcalCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4503/console Started: 2020/02/05 08:24

[cmsbuild]

+1
Tested at: 151256a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-455fe3/4503/summary.html
CMSSW: CMSSW_11_1_X_2020-02-04-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

+1
Tested at: 95e65b1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-455fe3/4517/summary.html
CMSSW: CMSSW_11_1_X_2020-02-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-455fe3/4517/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2698043
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2697696
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

hold
@bsunanda @ianna you wrote this PR makes use of #28863, but #28863 has been closed.
Could you comment on the status of this PR and #28863?

[cmsbuild]

Pull request has been put on hold by @silviodonato
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[bsunanda]

@silviodonato Please do not hold this. the content of the code which are changed here will remain unchanged irrespective of Ianna's PR is merged or not. I may have to modify some xml files later. These changes are only for dd4hep - it is not going to affect any workflows. I may have to change some xml files and then I have to test the effect of the changes on DDD and DD4Hep

[silviodonato]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[silviodonato]

@fabiocos I noticed there is a commit Merged refs/pull/28863/head from repository cms-sw with cms-merge-topic. Luckily, #28863 has not been merged yet, otherwise this commit would have created problems in the CMSSW history. Is it correct?