Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FastTimerService easier to use #28874

Merged
merged 2 commits into from Feb 7, 2020

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Feb 5, 2020

PR description:

The FastTimerService is used as the basis for circles (among other things).

The twiki page (linked above) describes how to use it, but requires manually editing configs generated by cmsDriver.

To make this easier to use, I put the code from the twiki into some functions that can be given to cmsDriver using --customise:

  • customise_timer_service
  • customise_timer_service_singlejob
  • customise_timer_service_multirun
  • customise_timer_service_print

I also added a simple harvesting config (which has to run standalone, so a customise function is not appropriate), which includes a multirun command-line argument.

@fwyzard if you agree with this approach, we can update the twiki to point out the availability of these convenience functions.

PR validation:

Tested the various customise functions and observed that they ran successfully and provided the expected input.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2020

The code-checks are being triggered in jenkins.

@kpedro88
Copy link
Contributor Author

kpedro88 commented Feb 5, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28874/13644

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4520/console Started: 2020/02/05 22:21

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2020

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

HLTrigger/Timer

@cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2020

+1
Tested at: 5001e26
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90128b/4520/summary.html
CMSSW: CMSSW_11_1_X_2020-02-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90128b/4520/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2698043
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697696
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fwyzard
Copy link
Contributor

fwyzard commented Feb 6, 2020

@kpedro88
thanks, looks good.

I cannot actually test it this week, and I'm thinking it could be useful to have the default behaviour in a cff file as well - but I can add that next week.

@fwyzard
Copy link
Contributor

fwyzard commented Feb 6, 2020

+1

@kpedro88
Copy link
Contributor Author

kpedro88 commented Feb 6, 2020

ping @cmsbuild

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants