MTD reco geometry: preliminary cleaning #28875

fabiocos · 2020-02-06T13:00:52Z

PR description:

This PR proposes a preliminary cleaning of the Geometry/MTDNumberingBuilder and Geometry/MTDGeometryBuilder in view of the migration to DD4hep and insertion of the new TRD ETL. The DD4hep DDFilteredView is updated by adding a method copyNumbers that has the same meaning as in DDD.

The GeometricTimingDetAnalyzer has also been revisited in order to provide a detailed dump of the product of the MTDNumberingBuilder and serve for comparisons in the rewriting of this component.

PR validation:

The old tests run on scenario D50 without issues, and now the printout in MTDTopologyAnalyzer is fixed (previously partially not working).

… remove code ported from tracker but unused by MTD, move testGeometry into more appropriate location, restore original GeometricTimingDet

cmsbuild · 2020-02-06T13:01:16Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-02-06T13:07:31Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28875/13649

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DetectorDescription/DDCMS/interface/DDFilteredView.h modified in PR(s): [DD4hep] Allow full regular expression in evaluation #28863

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28875/13649/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28875/13649/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-02-06T13:23:21Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-02-06T13:29:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28875/13650

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DetectorDescription/DDCMS/interface/DDFilteredView.h modified in PR(s): [DD4hep] Allow full regular expression in evaluation #28863

cmsbuild · 2020-02-06T13:29:47Z

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/MTDCommonData
Geometry/MTDGeometryBuilder
Geometry/MTDNumberingBuilder

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@vargasa this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

fabiocos · 2020-02-06T13:30:56Z

please test

cmsbuild · 2020-02-06T13:31:22Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4532/console Started: 2020/02/06 15:04

cmsbuild · 2020-02-06T15:20:41Z

+1
Tested at: c1d6aa9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed1190/4532/summary.html
CMSSW: CMSSW_11_1_X_2020-02-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-02-06T15:20:44Z

Comparison job queued.

cmsbuild · 2020-02-06T16:51:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed1190/4532/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2698043
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2697696
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

ianna · 2020-02-12T21:32:30Z

Geometry/MTDNumberingBuilder/test/MTDTopologyAnalyzer.cc

@@ -90,20 +92,29 @@ void MTDTopologyAnalyzer::analyze(const edm::Event& iEvent, const edm::EventSetu

    size_t num = fv.geoHistory().size();

-    if (fv.geoHistory()[num - 1].logicalPart().name() == "BarrelTimingLayer") {
+    if (fv.geoHistory()[num - 1].logicalPart().name().name() == "BarrelTimingLayer") {


@kpedro88 and @fabiocos - yes, a DDLogicalPart has a name() which is a DDName. The latter is a two strings object: a namespace() and a name(). Actually, every DD object has a DDName.

ianna · 2020-02-12T21:32:59Z

+1

cmsbuild · 2020-02-12T21:34:24Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-02-14T09:40:00Z

please test workflow 23434.1001

cmsbuild · 2020-02-14T09:40:25Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 23434.1001
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4662/console Started: 2020/02/14 10:46

cmsbuild · 2020-02-14T11:30:33Z

+1
Tested at: 5ddaaf0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed1190/4662/summary.html
CMSSW: CMSSW_11_1_X_2020-02-13-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-02-14T11:30:36Z

Comparison job queued.

cmsbuild · 2020-02-14T13:04:57Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed1190/4662/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ed1190/23434.1001_TTbar_14TeV+RecoFullGlobalPU_TestOldDigi_2026D49PU+HARVESTFullGlobalPU_2026D49PU

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2694005
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2693658
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

silviodonato · 2020-02-14T20:43:12Z

+1

Update DDD tests for RECO geometry to scenario D50, fix test classes,…

faf885a

… remove code ported from tracker but unused by MTD, move testGeometry into more appropriate location, restore original GeometricTimingDet

cmsbuild added this to the CMSSW_11_1_X milestone Feb 6, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Feb 6, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 6, 2020

scram b code-format

c1d6aa9

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 6, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 6, 2020

cmsbuild added tests-started and removed tests-pending labels Feb 6, 2020

cmsbuild added tests-approved and removed tests-started labels Feb 6, 2020

ianna approved these changes Feb 12, 2020

View reviewed changes

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Feb 12, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Feb 14, 2020

cmsbuild added tests-started and removed requires-external tests-pending labels Feb 14, 2020

cmsbuild added tests-approved and removed tests-started labels Feb 14, 2020

fabiocos added a commit to fabiocos/cmssw that referenced this pull request Feb 14, 2020

Update scenario as in cms-sw#28875 not yet merged

7d71d95

cmsbuild mentioned this pull request Feb 14, 2020

MTD RECO Geometry: fix debug statements in MTDGeometryBuilder #28964

Merged

cmsbuild added comparison-available and removed comparison-pending labels Feb 14, 2020

cmsbuild added orp-approved and removed orp-pending labels Feb 14, 2020

cmsbuild merged commit ccb6e55 into cms-sw:master Feb 14, 2020

fabiocos deleted the fc-mtd-recoclean branch February 19, 2020 14:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MTD reco geometry: preliminary cleaning #28875

MTD reco geometry: preliminary cleaning #28875

fabiocos commented Feb 6, 2020 •

edited

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

fabiocos commented Feb 6, 2020

cmsbuild commented Feb 6, 2020 •

edited

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

ianna Feb 12, 2020

ianna commented Feb 12, 2020

cmsbuild commented Feb 12, 2020

silviodonato commented Feb 14, 2020

cmsbuild commented Feb 14, 2020 •

edited

cmsbuild commented Feb 14, 2020

cmsbuild commented Feb 14, 2020

cmsbuild commented Feb 14, 2020

silviodonato commented Feb 14, 2020

MTD reco geometry: preliminary cleaning #28875

MTD reco geometry: preliminary cleaning #28875

Conversation

fabiocos commented Feb 6, 2020 • edited

PR description:

PR validation:

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

fabiocos commented Feb 6, 2020

cmsbuild commented Feb 6, 2020 • edited

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

cmsbuild commented Feb 6, 2020

ianna Feb 12, 2020

Choose a reason for hiding this comment

ianna commented Feb 12, 2020

cmsbuild commented Feb 12, 2020

silviodonato commented Feb 14, 2020

cmsbuild commented Feb 14, 2020 • edited

cmsbuild commented Feb 14, 2020

cmsbuild commented Feb 14, 2020

cmsbuild commented Feb 14, 2020

silviodonato commented Feb 14, 2020

fabiocos commented Feb 6, 2020 •

edited

cmsbuild commented Feb 6, 2020 •

edited

cmsbuild commented Feb 14, 2020 •

edited