Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEM DQM updates - full GE1/1, backport to 11_0_X #28878

Merged
merged 10 commits into from Feb 10, 2020

Conversation

quark2
Copy link
Contributor

@quark2 quark2 commented Feb 6, 2020

PR description:

This backport PR to 11_0_X (from #28769) updates and extends the part of onlineDQM for GEM. The details are following:

  • The existing parts are fixed to match the VFAT version which is used in CMSSW currently
  • Summary plot is added
  • Histograms which displays the status of devices (AMCs, GEBs, VFATs) by time are added

Please see this to check more details, especially the visualization with DQM GUI (there is also an update for GEM part for onlineDQM GUI, which will be PRed soon)

PR validation:

Test are done and one can check again by runTheMatrix workflows

@jshlee @watson-ij

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2020

A new Pull Request was created by @quark2 for CMSSW_11_0_X.

It involves the following packages:

DQM/GEM

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@quark2 quark2 changed the title GEM DQM upates - full GE1/1, backport to 11_0_X GEM DQM updates - full GE1/1, backport to 11_0_X Feb 6, 2020
@jfernan2
Copy link
Contributor

jfernan2 commented Feb 6, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4535/console Started: 2020/02/06 22:12

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2020

+1
Tested at: 867e219
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a23931/4535/summary.html
CMSSW: CMSSW_11_0_X_2020-02-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a23931/4535/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793497
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 7, 2020

hold
Testing it in Online DQM playback

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2020

Pull request has been put on hold by @jfernan2
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@silviodonato
Copy link
Contributor

@quark2 Could you quote the number of the CMSSW_11_1_X PR in the description?

@fioriNTU
Copy link
Contributor

fioriNTU commented Feb 7, 2020

@quark2
Copy link
Contributor Author

quark2 commented Feb 7, 2020

@silviodonato okay, I added

@silviodonato
Copy link
Contributor

backport #28769
@quark2 thanks

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 7, 2020

unhold
Tested succesfully in DQM Online playback

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2a9664e into cms-sw:CMSSW_11_0_X Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants