Clean BuildFiles in RecoVertex and RecoTracker #28882
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28882/13660
|
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: RecoTracker/DeDx @perrotta, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 9c8f24f CMSSW: CMSSW_11_1_X_2020-02-07-1100 I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: /cvmfs/cms-ib.cern.ch/nweek-02614/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: TrackerGeometryCompare.cc:(.text+0x1461): undefined reference to `std::type_info const& edm::typelookup::classTypeInfo()'
/cvmfs/cms-ib.cern.ch/nweek-02614/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: TrackerGeometryCompare.cc:(.text+0x16d4): undefined reference to `SiPixelQuality::IsModuleBad(unsigned int const&) const'
/cvmfs/cms-ib.cern.ch/nweek-02614/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: TrackerGeometryCompare.cc:(.text+0x21e1): undefined reference to `char const* edm::typelookup::className()'
/cvmfs/cms-ib.cern.ch/nweek-02614/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc820/src/Alignment/OfflineValidation/plugins/AlignmentOfflinevalidationPlugins/TrackerGeometryCompare.cc.o: in function `edm::eventsetup::EventSetupRecordImpl::getImplementation(SiPixelQuality const*&, char const*, edm::eventsetup::ComponentDescription const*&, bool, std::shared_ptr&, edm::EventSetupImpl const*) const::{lambda()#1}::operator()() const':
TrackerGeometryCompare.cc:(.text._ZZNK3edm10eventsetup20EventSetupRecordImpl17getImplementationI14SiPixelQualityEEvRPKT_PKcRPKNS0_20ComponentDescriptionEbRSt10shared_ptrINS_24ESHandleExceptionFactoryEEPKNS_14EventSetupImplEENKUlvE_clEv[_ZZNK3edm10eventsetup20EventSetupRecordImpl17getImplementationI14SiPixelQualityEEvRPKT_PKcRPKNS0_20ComponentDescriptionEbRSt10shared_ptrINS_24ESHandleExceptionFactoryEEPKNS_14EventSetupImplEENKUlvE_clEv]+0x56): undefined reference to `char const* edm::typelookup::className()'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc820/src/Alignment/OfflineValidation/plugins/AlignmentOfflinevalidationPlugins/libAlignmentOfflinevalidationPlugins.so] Error 1
Leaving library rule at src/Alignment/OfflineValidation/plugins
Entering library rule at Alignment/OfflineValidation
>> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-07-1100/src/Alignment/OfflineValidation/src/TrackerValidationVariables.cc
>> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-07-1100/src/Alignment/OfflineValidation/src/PVValidationHelpers.cc
|
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
|
The code-checks are being triggered in jenkins. |
|
For all the dependencies I added in this PR now, the git grepping shows they are actually used. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
| @@ -24,5 +24,6 @@ | |||
| <use name="TrackingTools/PatternTools"/> | |||
| <use name="TrackingTools/TrackFitters"/> | |||
| <use name="TrackingTools/MeasurementDet"/> | |||
| <use name="TrackingTools/KalmanUpdators"/> | |||
There was a problem hiding this comment.
For my education, why do you need to add TrackingTools/KalmanUpdators?
There was a problem hiding this comment.
Because it's included here and in the line after:
https://github.com/cms-sw/cmssw/blob/master/CalibTracker/SiStripHitEfficiency/interface/HitEff.h#L14
Before, it somehow got this dependency indirectly by one of the used RecoTracker packages, but since the dependencies got cleaned there this didn't happen anymore. That's why we have to declare the dependency at this right place now.
| @@ -5,6 +5,7 @@ | |||
| <use name="CondCore/DBOutputService"/> | |||
| <use name="CondFormats/Alignment"/> | |||
| <use name="CondFormats/RunInfo"/> | |||
| <use name="CondFormats/SiPixelObjects"/> | |||
There was a problem hiding this comment.
It is used here: https://github.com/cms-sw/cmssw/blob/master/Alignment/OfflineValidation/plugins/TrackerGeometryCompare.cc#L18
Again, this was not an issue before because it somehow got this dependency indirectly via some RecoTracker package, but now it's done right.
|
+1 |
PR description:
Another quick round of automatic BuildFile.xml cleaning to improve the modularity of CMSSW.
PR validation:
CMSSW compiles.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport intended.