Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eta cut for PFCandidates in Scouting #28896

Merged
merged 2 commits into from Feb 10, 2020

Conversation

jsalfeld
Copy link
Contributor

@jsalfeld jsalfeld commented Feb 8, 2020

PR description:

Added Eta cut option for PFCandidates to HLTScoutinfPFProducer. Once restricted to |eta|<3, the event size decreases by roughly factor 2.

PR validation:

I checked running with and without the cut and checked the event content everything is as expected.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28896/13682

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2020

A new Pull Request was created by @jsalfeld (Jakob Salfeld-Nebgen) for master.

It involves the following packages:

HLTrigger/JetMET

@cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Feb 8, 2020

please use std::abs instead of fabs .

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28896/13683

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2020

Pull request #28896 was updated. @cmsbuild, @Martin-Grunewald, @fwyzard can you please check and sign again.

@fwyzard
Copy link
Contributor

fwyzard commented Feb 9, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4560/console Started: 2020/02/09 10:03

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2020

+1
Tested at: b524bb6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ef2af/4560/summary.html
CMSSW: CMSSW_11_1_X_2020-02-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ef2af/4560/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2698043
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697696
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4b3ed36 into cms-sw:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants