[HGCAL] TICL technical changes

[rovere]

PR description:

This PR is another step toward the inclusion of TICL into the Phase2 reconstruction sequence. This PR, in particular, fixes a few bugs and add templated data structures that will be used in future internally by TICL and, possibly, other detectors (HFNose, in particular). In more details:

• Correct the cone direction while running the Pattern Recognition
• Fix the phi search window
• Fix the charge assignment to TICL Candidates
• Fix energy regression input variables
• Template TICL Tile data structures.

PR validation:

The usual limited Matrix.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28903/13690

• This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28903/13690/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28903/13690/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28903/13692

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

DataFormats/HGCalReco
RecoHGCal/TICL

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @riga, @apsallid, @sobhatta, @lecriste, @hatakeyamak, @clelange this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4580/console Started: 2020/02/10 17:04

[cmsbuild]

+1
Tested at: 4cfb43a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4110ae/4580/summary.html
CMSSW: CMSSW_11_1_X_2020-02-10-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4110ae/4580/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2694005
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2693658
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[kpedro88]

+upgrade

[perrotta]

+1

• Code changes are in line with the PR description
• Jenkins tests pass with no difference (no TICL reco in them)
• Verified running in a wf which includes TICL: 20493.52
  • Changes in objects follow what implemented (eg. charge of the TICL candidate)
  • A few more candidates (241 vs 239) selected in a test run with that wf, mostly, with apparently no changes in the other parameters (energy, eta, etc.) of the candidates in common)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1