Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of replaced Configuration/Geometry/DD4hep_GeometrySim_cff fragment #28922

Merged
merged 1 commit into from Feb 11, 2020

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Feb 11, 2020

PR description:

In #28847 Configuration.Geometry.DD4hep_GeometrySim_cff has been renamed to a more standard GeometryDD4hepExtended2021_cff to allow developers to use it with cmsDriver.py. This PR fixes the two residual places where this update has not been propagated.

PR validation:

Code compiles, validateGEMGeometry_cfg.py does not complain any more because of the missing fragment (but it fails for apparently unrelated issues, @slomeo FYI).

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28922/13719

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/StandardSequences
Geometry/TrackerNumberingBuilder

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @silviodonato, @franzoni, @kpedro88, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @ebrondol, @dgulhan, @venturia this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

bug-fix

@fabiocos
Copy link
Contributor Author

type bug-fix

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 11, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4595/console Started: 2020/02/11 15:12

@cmsbuild
Copy link
Contributor

+1
Tested at: 6e3659f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f6de5/4595/summary.html
CMSSW: CMSSW_11_1_X_2020-02-10-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f6de5/4595/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2694005
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2693658
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

urgent

@cvuosalo
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor

+operations

@silviodonato
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 1eb6db4 into cms-sw:master Feb 11, 2020
@fabiocos fabiocos deleted the fc-fixConfig branch February 19, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants