EventSetup consumes migration 1 GEM module and 1 L1T module

[wddgit]

PR description:

EventSetup consumes migration for 2 modules,
GEMRawToDigiModule and
L1TMuonOverlapTrackProducer

Also migrated helper classes used by L1TMuonOverlapTrackProducer.

Also a little cleanup related to the includes and forward declarations.
Also cleanup, removed a data member containing an unnecessary
copy of the module's ParameterSet.

PR validation:

Should not change output. Relies on existing tests.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28926/13726

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

EventFilter/GEMRawToDigi
L1Trigger/L1TMuonOverlap

@perrotta, @rekovic, @benkrikler, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jshlee, @Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4611/console Started: 2020/02/11 21:22

[cmsbuild]

+1
Tested at: b68094f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f6591/4611/summary.html
CMSSW: CMSSW_11_1_X_2020-02-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f6591/4611/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2694005
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2693658
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[rekovic]

+1

[perrotta]

please test
(to refresh them)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4859/console Started: 2020/02/25 12:10

[cmsbuild]

+1
Tested at: b68094f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f6591/4859/summary.html
CMSSW: CMSSW_11_1_X_2020-02-24-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f6591/4859/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2695371
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2695049
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[perrotta]

+1

• Technical
• Jenkins tests pass and show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1