solve a long standing performance issue with Vertex::TrackWeight #2894
Conversation
|
A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_1_X. solve a long standing performance issue with Vertex::TrackWeight It involves the following packages: DataFormats/VertexReco @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks. |
| ///returns the weight with which a Track has contributed to the vertex-fit. | ||
| float trackWeight ( const TrackBaseRef & r ) const; | ||
| ///returns the weight with which a Track has contributed to the vertex-fit. | ||
| float trackWeight ( const TrackRef & r ) const; |
There was a problem hiding this comment.
do we not need a definition of trackWeight when we do not have C++11?
There was a problem hiding this comment.
Good point,
@vadler @Dr15Jones @alja
maybe Volker or Chris or Alja could comment if it's actively used in FWLite-based code.
(I never trust using Refs in FWLite, but that's mostly based on TChain experience reading from multiple files).
Other than "auto", this is a regular C++, so this code can be changed for compliance
There was a problem hiding this comment.
I though about it (after had deleted the old code)
is trivial
#else
old interface
#endif
I did in other places...
There was a problem hiding this comment.
Seems to me that we either need no ifdef or an else
On Mar 19, 2014, at 12:16 PM, "Vincenzo Innocente" <notifications@github.commailto:notifications@github.com> wrote:
In DataFormats/VertexReco/interface/Vertex.h:
///returns the weight with which a Track has contributed to the vertex-fit.
- float trackWeight ( const TrackBaseRef & r ) const;
- ///returns the weight with which a Track has contributed to the vertex-fit.
- float trackWeight ( const TrackRef & r ) const;
I though about it (after had deleted the old code)
is trivial
#else
old interface
#endif
I did in other places...
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2894/files#r10744729.
There was a problem hiding this comment.
On 3/19/14, 6:15 AM, Vincenzo Innocente wrote:
In DataFormats/VertexReco/interface/Vertex.h:
///returns the weight with which a Track has contributed to the vertex-fit.
- float trackWeight ( const TrackBaseRef & r ) const;
- ///returns the weight with which a Track has contributed to the vertex-fit.
- float trackWeight ( const TrackRef & r ) const;
I though about it (after had deleted the old code)
is trivial
#else
old interface
#endif
I did in other places...
Still confused. Isn't the only c++11 thing here the
"for (auto t: tracks_)" ?
If so, there's no cost to write the same with vector::const_iterator
Did I miss something?
--slava
—
Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/2894/files#r10744729.
Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)
There was a problem hiding this comment.
On 19 Mar, 2014, at 1:10 PM, slava77 notifications@github.com wrote:
Still confused. Isn't the only c++11 thing here the "for (auto t: tracks_)" ? If so, there's no cost to write the same with vector::const_iterator Did I miss something?
I think that tempplates are a bit useless in FWLite or similar.
They need generated function or template instantiation…
v.
|
test again? |
solve a long standing performance issue with Vertex::TrackWeight
may be used elsewhere