[URGENT] fix for getting clang version which is breaking 11.1.0.pre3 release

[smuzaffar]

PR description:

11.1.0.pre3 build are failing with error [a]. Looks like, while building release, clang returns something like

clang --version | grep 'clang version'
clang version 9.0.1 (/data/cmsbld/jenkins/workspace/auto-builds/CMSSW_11_1_0_pre3-slc7_amd64_gcc900/build/CMSSW_11_1_0_pre3-build/BUILD/slc7_amd64_gcc900/external/llvm/9.0.1/llvm-9.0.1-379a43bc841451feccf78db64f2ed5c9e62c7de8/clang 9979c02b51651889403625605dbd1409249d29fd)

note the extra (...) part which breaks condformats_serialization_generate.py. No idea why it is not failing for IBs where clang properly returns

>pwd
/build/muz/d/CMSSW_11_1_X_2020-02-12-2300
>clang --version | grep 'clang version'
clang version 9.0.1

this change makes sure that we only process the first part of version starting. We need to get this in as soon as possible to get going with 11.1.0.pre3 build

[a]

File ".../CMSSW_11_1_0_pre3/src/CondFormats/Serialization/python/condformats_serialization_generate.py", line 355, in get_clang_version
(clang_version_major, clang_version_minor, clang_version_patchlevel) = subprocess.check_output(command, shell=True).splitlines()[0].decode('ascii').strip().split('.', 3) ValueError: too many values to unpack

[smuzaffar]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28947/13760

• This PR adds an extra 8KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4636/console Started: 2020/02/13 08:48

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CondFormats/Serialization

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

urgent
thanks @smuzaffar for the quick fix!

[cmsbuild]

+1
Tested at: 81ae544
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-717203/4636/summary.html
CMSSW: CMSSW_11_1_X_2020-02-12-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[silviodonato]

merge

[silviodonato]

I wanted this fix in the next IB

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-717203/4636/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2694005
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2693658
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[smuzaffar]

@fwyzard , Patatrack IBs are failing [a] . I think you are missing this update in Patatrack .

[a]

Traceback (most recent call last):
  File "CMSSW_11_1_Patatrack_X_2020-02-17-2300/src/CondFormats/Serialization/python/condformats_serialization_generate.py", line 604, in <module>
    main()
  File "CMSSW_11_1_Patatrack_X_2020-02-17-2300/src/CondFormats/Serialization/python/condformats_serialization_generate.py", line 601, in main
    SerializationCodeGenerator( scramFlags=args[1:] ).generate( opts.output )
  File "CMSSW_11_1_Patatrack_X_2020-02-17-2300/src/CondFormats/Serialization/python/condformats_serialization_generate.py", line 508, in __init__
    self.classes = get_serializable_classes_members(translation_unit.cursor, only_from_path=self._join_package_path())
  File "CMSSW_11_1_Patatrack_X_2020-02-17-2300/src/CondFormats/Serialization/python/condformats_serialization_generate.py", line 203, in get_serializable_classes_members
    if not is_friend_decl(member.kind):
  File "CMSSW_11_1_Patatrack_X_2020-02-17-2300/src/CondFormats/Serialization/python/condformats_serialization_generate.py", line 362, in is_friend_decl
    clangv = get_clang_version()
  File "CMSSW_11_1_Patatrack_X_2020-02-17-2300/src/CondFormats/Serialization/python/condformats_serialization_generate.py", line 355, in get_clang_version
    (clang_version_major, clang_version_minor, clang_version_patchlevel) = subprocess.check_output(command, shell=True).splitlines()[0].decode('ascii').strip().split('.', 3)
  ValueError: too many values to unpack

[fwyzard]

Is it because the Patatrack IBs get the latest version of the externals, even though they do not get the CMSSW updates ?

[smuzaffar]

yes, Patatrack uses the same externals we use for building normal 11.1.x IBs

[fwyzard]

OK, I've backported the fix to the patatrack branch.