Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCALDQM: Fix ngHO crate-FED mapping (11_0_X) #28954

Closed
wants to merge 1 commit into from

Conversation

DryRun
Copy link
Contributor

@DryRun DryRun commented Feb 13, 2020

Backport of #28952

PR description:
This PR fixes the ngHO crate-FED mapping implemented in #28484. The mapping changed a bit since that PR, so HCAL is crashing the DQM playback again. There was some further work done, and crate 38 ended up being used, instead of 33. See that thread for more info on the expected changes.

This probably has cropped up a few times now, and might happen again in the future. We plan to move away from the hard-coded crate-FED map. A couple ideas:

  1. Change from FED to something like RBX. HCAL ops doesn't like FED anyways, since it doesn't correspond to anything physical and is subject to change in the future (depending on the zero-suppression strategy at higher radiation damage, HCAL may move to 3 FEDs / crate).
  2. Make FED available through conditions. Seems like a lot of work just to have FED on a plot axis.

PR validation:
Fixes the crash in playback. Passed runTheMatrix.py -l limited -i all --ibeos without error.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 13, 2020

A new Pull Request was created by @DryRun (David Yu) for CMSSW_11_0_X.

It involves the following packages:

DQM/HcalCommon

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@DryRun DryRun closed this Feb 13, 2020
@DryRun
Copy link
Contributor Author

DryRun commented Feb 13, 2020

The commits in this backport don't correspond exactly to the master PR. Closing and redoing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants