Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a read error and not a generic error when an LHE read fails #2897

Merged
merged 1 commit into from Mar 26, 2014

Conversation

PerilousApricot
Copy link

Hello,

Not sure how to get this submitted for all the different versions of CMSSW (manually?), but I guess it should be eventually.

When LHE reads fail (which happens a decent bit with xrootd), a generic CMSSW exception is thrown, which causes problems with the job retry mechanism of CRAB3. This fix throws a read error instead, which is on the whitelist of acceptable-to-retry errors.

Thanks!

@bbockelm

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @PerilousApricot (Andrew Melo) for CMSSW_5_3_X.

Throw a read error and not a generic error when an LHE read fails

It involves the following packages:

GeneratorInterface/LHEInterface

@vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vciulli
Copy link
Contributor

vciulli commented Mar 18, 2014

@PerilousApricot: to submit it to different CMSSW version you can easily cherry-pick this commit in a different release
cmsrel CMSSW_whatever
cd CMSSW_whatever/src
cmsenv
git fetch my-cmssw lhe_read_error
git cherry-pick 055e066
git checkout -b lhe_read_error_whatever
git push my-cmsse lhe_read_error_whatever

then proceed as usual with the pull request

@vciulli
Copy link
Contributor

vciulli commented Mar 18, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@davidlange6
Copy link
Contributor

+1

@smuzaffar
Copy link
Contributor

+1

smuzaffar added a commit that referenced this pull request Mar 26, 2014
Throw a read error and not a generic error when an LHE read fails
@smuzaffar smuzaffar merged commit 9742e6a into cms-sw:CMSSW_5_3_X Mar 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants