Clean BuildFiles in RecoHI and RecoLocalMuon

[guitargeek]

PR description:

Another quick round of automatic BuildFile.xml cleaning to improve the modularity of CMSSW.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28972/13804

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

RecoHI/HiCentralityAlgos
RecoHI/HiEgammaAlgos
RecoHI/HiEvtPlaneAlgos
RecoHI/HiMuonAlgos
RecoHI/HiTracking
RecoLocalMuon/CSCEfficiency
RecoLocalMuon/CSCRecHitD
RecoLocalMuon/CSCValidation
RecoLocalMuon/GEMRecHit
RecoLocalMuon/RPCRecHit

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@echapon, @abbiendi, @MiheeJo, @jazzitup, @jshlee, @bellan, @yenjie, @jhgoh, @kurtejung, @ptcox, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4704/console Started: 2020/02/17 14:46

[cmsbuild]

+1
Tested at: 2878068
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-160e13/4704/summary.html
CMSSW: CMSSW_11_1_X_2020-02-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-160e13/4704/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2694005
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2693658
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[kpedro88]

+upgrade

[slava77]

this looks like a fake dependency.
May I ask you to cleanup the includes in RecoHI/HiEvtPlaneAlgos/src/HiEvtPlaneFlatProducer.cc which apparently does not need anything from Sim*.

[guitargeek]

You are right, these Sim dependencies in Reco are not really good. I'll remove it.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28972/13843

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #28972 was updated. @perrotta, @cmsbuild, @kpedro88, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4790/console Started: 2020/02/19 22:34

[cmsbuild]

+1
Tested at: 58e74e3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-160e13/4790/summary.html
CMSSW: CMSSW_11_1_X_2020-02-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-160e13/4790/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2694086
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2693766
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

+1

for #28972 58e74e3

• code changes are in line with the PR description and the follow up review: cleanup of dependencies and some unused files or includes
• jenkins tests pass and comparisons with the baseline show no differences

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1