New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add class version #2901
add class version #2901
Conversation
A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_1_X. add class version It involves the following packages: DataFormats/Candidate @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks. |
+1 |
@ktf @davidlange6 Giulio and David, does it make sense that Candidate is in AT category, but not in RECO? |
I guess that's historical. I can change it if @davidlange6 agrees. |
yes, reco definitely needs to review anything in Candidate. On Mar 18, 2014, at 9:18 AM, Giulio Eulisse notifications@github.com
|
-1 runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step3_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log ----- Begin Fatal Exception 18-Mar-2014 12:14:17 CET----------------------- An exception of category 'FallbackFileOpenError' occurred while [0] Constructing the EventProcessor [1] Constructing input source of type PoolSource [2] Calling RootInputFileSequence::initFile() [3] Calling StorageFactory::open() [4] Calling XrdFile::open() Exception Message: Failed to open the file 'root://xrootd.ba.infn.it//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root' Additional Info: [a] Input file root://eoscms//eos/cms/store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root?svcClass=default could not be opened. Fallback Input file root://xrootd.ba.infn.it//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root also could not be opened. [b] XrdClient::Open(name='root://xrootd.ba.infn.it//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root', flags=0x10, permissions=0666) => error 'cannot obtain credentials for protocol: Secgsi: ErrParseBuffer: error getting user proxies: kXGS_init: unable to get protocol object.' (errno=3010) [c] Current server connection: root://xrootd.ba.infn.it:1094//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: |
run again |
Given this is unrelated, and all the other tests pass, I'm merging this. |
Misc fixes -- Add class version for Candidate.
needed to evolve further candiate
We need to check ALL other template class in DataFormats
only those in Common are properly versioned
one is 11: does not matter