Run3-alca161 Correct some of the scripts used for IsoTrack Calibration

[bsunanda]

PR description:

Correct some of the scripts for PU correction to be used for isotrack calibration

PR validation:

Tested privately using MC samples and results presented in the HCAL DPG

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special;

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29017/13865

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/HcalCalibAlgos

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[christopheralanwest]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4817/console Started: 2020/02/21 17:25

[cmsbuild]

+1
Tested at: 75334b2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aea9c0/4817/summary.html
CMSSW: CMSSW_11_1_X_2020-02-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aea9c0/4817/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2694086
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2693766
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[pohsun]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

@bsunanda, could you extend the PR description, please?
I see you are adding some commented lines, a new function (combine) that is not used, some changes in the file name. The actual change seems in https://github.com/cms-sw/cmssw/pull/29017/files#diff-c718505a17e3de9a782dd5614a3bdeaaR144-R156 and https://github.com/cms-sw/cmssw/pull/29017/files#diff-0c8d163a2377a93b975dc456b3f9d414R74-R75 . Thanks!

[silviodonato]

+1