-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQMCertCommon is not used, customize DQMCertTrackerPixel instead #29021
Conversation
The code-checks are being triggered in jenkins. |
I tried to test the Tier-0 setup with:
but apparently the right harvesting sequences are not picked up. I am not sure how it is possible to configure a specific harvesting sequence using |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29021/13872
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: DQMOffline/Configuration @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Any idea @andrius-k @jfernan2 @kmaeshima @fioriNTU @schneiml ? |
@mmusich @silviodonato you might have better luck with these tools: https://twiki.cern.ch/twiki/bin/view/CMSPublic/DqmWrappers |
@silviodonato what's holding this PR? @schneiml, |
@mmusich This is what T0 provided to us as "the truth". If it behaves differently from T0 itself, I think that should be considered a bug on their side. |
@schneiml, I am not saying there is any bug, what I am still missing is how to configure any of these tool to accept an harvesting sequence different from the default (i.e |
@mmusich The database queried by this wrapper indeed knows the sequence [1], but the script seems to not use it. Some experiments I just did show that the old But clearly, using [1] https://cmsweb.cern.ch/t0wmadatasvc/prod/reco_config?run=335443&primary_dataset=MinimumBias |
+1 |
maybe @andresfelquintero can shed some light?
This goes along the lines of the message: https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/2161/1/1/1.html (which by the way seems it has already been implemented by Tier-0 judging from https://cmsweb.cern.ch/t0wmadatasvc/prod/reco_config). |
So I am currently checking the bug as suggested by @schneiml . The problem with my wrapper is that it uses DQMHarvesting.py and I do not have a way of defining the correct harvesting sequence right now. As @mmusich says, I changed the dqm_seq on tier0 headnode when the DQM team gave us authorization. From now on it won't include @common or any other sequence rather than the desired one. We are looking into the problem now, and I think it is related to how we take the dqm sequences for replay, as it may be different from how we do it on production regarding the dqm sequence picking for processing. |
PR description:
Minimal fix for issue described at https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/2161.html.
DQMCertCommon
is de facto not used (https://github.com/cms-sw/cmssw/search?q=DQMCertCommon&unscoped_q=DQMCertCommon) and can be removed.PR validation:
I tested with
runTheMatrix.py -l limited -i all -t 4 -j 8 --ibeos
.if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport.