Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected 5 channels of 2016 ECAL intercalibration [11_0_X] #29028

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR is a backport of PR #29023.

This PR corrects five channels of the 2016 ECAL intercalibration that JetMET identified as problematic during the 2016 UL validation. Only the offline data GTs are updated, with only a single tag update, as seen in the GT diffs below:

Offline data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_v11/110X_dataRun2_v12
Offline data relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_relval_v11/110X_dataRun2_relval_v12

PR validation:

See the presentation at the 10 Feb 2020 AlCaDB meeting and the 20 Feb 2020 PPD meeting for details of the validation.

In addition, a technical test was performed: runTheMatrix -l limited --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of PR #29023. The updates in this PR are included in the 2016 UL reprocessing. Since this bug fix is included in 10_6_X and in master, it is desirable to have the 11_0_X offline data GTs updated for consistency.
This PR is a backport of PR #29023. The updates in this PR are included in the 2016 UL reprocessing.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for CMSSW_11_0_X.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4843/console Started: 2020/02/24 16:36

@cmsbuild
Copy link
Contributor

+1
Tested at: 8dabeab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c3c18/4843/summary.html
CMSSW: CMSSW_11_0_X_2020-02-24-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c3c18/4843/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 30 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 24
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793475
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@christopheralanwest christopheralanwest changed the title Corrected 5 channels of 2016 ECAL intercalibration Corrected 5 channels of 2016 ECAL intercalibration [11_0_X] Feb 24, 2020
@christopheralanwest
Copy link
Contributor Author

+1

  • Changes seen only in 2016 data workflow, as expected. Identical changes in PR comparison tests to those in master branch.
  • ECAL intercalibration tag validated in offline tests, as described in the introduction this this PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 68a8fe4 into cms-sw:CMSSW_11_0_X Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants